Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bug reading password from a buffer when reader returns EOF #11796

Conversation

Vizualni
Copy link
Contributor

@Vizualni Vizualni commented Apr 27, 2022

Description

When providing a password from a io.Reader it returns io.EOF when it's done reading. Function readLineFromBuf then returns the error and discards the password read.
This fixes it and there are tests verifying the behaviour.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@Vizualni Vizualni changed the title Bug fix for reading password from a buffer when reader returns EOF [A bug fix] Reading password from a buffer when reader returns EOF Apr 27, 2022
@github-actions github-actions bot added the C:CLI label Apr 27, 2022
@Vizualni Vizualni changed the title [A bug fix] Reading password from a buffer when reader returns EOF Fix reading password from a buffer when reader returns EOF Apr 27, 2022
@Vizualni Vizualni changed the title Fix reading password from a buffer when reader returns EOF bug: Fix reading password from a buffer when reader returns EOF Apr 27, 2022
@Vizualni Vizualni changed the title bug: Fix reading password from a buffer when reader returns EOF fix: Bug reading password from a buffer when reader returns EOF Apr 27, 2022
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

client/input/input.go Outdated Show resolved Hide resolved
client/input/input.go Show resolved Hide resolved
@alexanderbez alexanderbez added backport/0.45.x backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release A:automerge Automatically merge PR once all prerequisites pass. labels Apr 27, 2022
Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com>
@Vizualni
Copy link
Contributor Author

@alexanderbez thanks for the review. I've applied your suggestions :)

@alexanderbez
Copy link
Contributor

@Vizualni can you enable access for pushing/updating on your forks? That way, you don't have to keep manually updating.

@Vizualni
Copy link
Contributor Author

Hey @alexanderbez. Could you explain to me what exactly I need to do here? I don't see any restriction which tells me that you shouldn't be able to do this. Also, there is test-race(00) that fails. Is this something that's known or was it introduced with this PR?

@alexanderbez
Copy link
Contributor

I don't remember the exact setting you have to change. @marbar3778 do you recall?

@Vizualni Vizualni deleted the mm/fix-bug-when-taking-pass-inputs-for-keyring branch April 28, 2022 09:40
randy75828 pushed a commit to Switcheo/cosmos-sdk that referenced this pull request Aug 10, 2022
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. backport/0.46.x PR scheduled for inclusion in the v0.46's next stable release C:CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants