Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update StartHeight signing info in AfterValidatorBonded hook when validator re-bonds #11973

Merged
merged 5 commits into from
May 18, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented May 16, 2022

Description

Closes: #10312

This PR fixes the mismatch between the behavior and the comment, as discovered in the issue above.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt changed the title test: improve TestValidatorDippingInAndOut fix: update StartHeight signing info in AfterValidatorBonded hook when validator re-bonds May 18, 2022
@julienrbrt julienrbrt marked this pull request as ready for review May 18, 2022 10:58
@julienrbrt julienrbrt requested a review from a team as a code owner May 18, 2022 10:58
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #11973 (cb9ba34) into main (23baecf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #11973   +/-   ##
=======================================
  Coverage   65.97%   65.97%           
=======================================
  Files         677      677           
  Lines       71336    71341    +5     
=======================================
+ Hits        47061    47065    +4     
- Misses      21590    21591    +1     
  Partials     2685     2685           
Impacted Files Coverage Δ
x/slashing/keeper/hooks.go 80.00% <100.00%> (+2.22%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 82.45% <0.00%> (-1.76%) ⬇️

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexanderbez alexanderbez merged commit 0fa90ad into main May 18, 2022
@alexanderbez alexanderbez deleted the julien/improve-test-slashing branch May 18, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

misleading documentation about ValidatorSigningInfo.StartHeight
3 participants