Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bank): Create message for Setting SendEnabled settings #11981

Merged
merged 165 commits into from
Sep 9, 2022

Conversation

dwedul-figure
Copy link
Collaborator

@dwedul-figure dwedul-figure commented May 17, 2022

Description

Closes: #11859

This PR is related to #11977. It creates and implements MsgSetSendEnabled, a message for use as a governance proposal to update the SendEnabled information.

Note that this PR is currently set to merge into dwedul/11859-send-disabled-change instead of main. This PR is dependent on functionality added by that branch. Once that PR has merged into main, I'll update this to also merge into main.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change N/A
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

…endEnabledCoins. Store creation has some overhead.
…ple TODO notes. Create a way to iterate over the SendEnabled entries and get all of them.
…ed entries similar to when they were params.
# Conflicts:
#	api/cosmos/bank/v1beta1/bank.pulsar.go
#	api/cosmos/bank/v1beta1/genesis.pulsar.go
…o longer returns {} when there aren't any SendEnabled entries and the default is false. SendEnabled is back to outputting a yaml format.
@dwedul-figure
Copy link
Collaborator Author

@dwedul-figure are you waiting on a review from the sdk team here?

Yup. Sorry, I had let it get a bit behind, but it's all good now.

There's just the question of the SetSendEnabled endpoint vs UpdateParams. As things are right now (in this branch), the SetSendEnabled can do everything that UpdateParams does. That suggests we might want to get rid of the UpdateParams endpoint. However, UpdateParams is a standard for modules that have params, so it might be worth keeping it around (for familiarity). Along that line, if a param were ever added to the bank module that isn't associated with the send-enabled stuff, we'd want an UpdateParams endpoint for sure.

My personal gut feeling is to have both; the overlapping responsibilities are small enough that it shouldn't be much of an extra burden. But I also don't mind getting rid of UpdateParams. Another alternative is to remove the default stuff from SetSendEnabled, but I'm not a fan of that option. I feel like there will be times when it is desirable to set some flags and change the default, all at the same time and make them part of the same governance proposal.

Just let me know which direction I should go on that.

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

# Conflicts:
#	CHANGELOG.md
#	x/bank/spec/03_messages.md
#	x/bank/spec/README.md
…mos/cosmos-sdk into dwedul/11859-send-enabled-w-gov-prop

# Conflicts:
#	CHANGELOG.md
…mos-sdk/simapp) in x/bank/app_test.go and update other go mod stuff associated with that.
@tac0turtle tac0turtle merged commit 6a6e6c7 into main Sep 9, 2022
@tac0turtle tac0turtle deleted the dwedul/11859-send-enabled-w-gov-prop branch September 9, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Bank Module Send Disabled Token Configuration
8 participants