Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: index ante events for failed tx #12013

Merged
merged 4 commits into from
May 23, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented May 23, 2022

Description

Currently the ante events for failed tx are not indexed at all, but ethermint need to rely on them to find some failed txs in json-rpc apis.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@yihuang yihuang requested a review from a team as a code owner May 23, 2022 10:16
CHANGELOG.md Outdated Show resolved Hide resolved
@yihuang yihuang changed the title index ante events for failed tx fix: index ante events for failed tx May 23, 2022
@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #12013 (4a68e0f) into main (d416ee8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main   #12013   +/-   ##
=======================================
  Coverage   65.97%   65.97%           
=======================================
  Files         671      671           
  Lines       70959    70959           
=======================================
+ Hits        46815    46816    +1     
+ Misses      21490    21488    -2     
- Partials     2654     2655    +1     
Impacted Files Coverage Δ
baseapp/abci.go 64.05% <100.00%> (ø)
x/group/keeper/keeper.go 54.85% <0.00%> (+0.42%) ⬆️

Co-authored-by: yihuang <huang@crypto.com>
@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label May 23, 2022
@alexanderbez alexanderbez merged commit 3c0f55c into cosmos:main May 23, 2022
@yihuang yihuang deleted the index-failed-events branch May 23, 2022 15:32
randy75828 pushed a commit to Switcheo/cosmos-sdk that referenced this pull request Aug 10, 2022
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants