Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: legacyP2P #12067

Closed
wants to merge 12 commits into from
Closed

test: legacyP2P #12067

wants to merge 12 commits into from

Conversation

tac0turtle
Copy link
Member

Description

test using legacy P2P to solve new issues


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@amaury1093 amaury1093 mentioned this pull request May 27, 2022
19 tasks
@tac0turtle tac0turtle marked this pull request as ready for review May 27, 2022 13:06
@tac0turtle tac0turtle requested a review from a team as a code owner May 27, 2022 13:06
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @AmauryM can you test again with these changes?

server/util.go Show resolved Hide resolved
@alexanderbez alexanderbez added the A:automerge Automatically merge PR once all prerequisites pass. label May 27, 2022
@kaustubhkapatral
Copy link
Contributor

Using the config file generated from this branch fixes the network stall mentioned in this issue after a software upgrade. #12041

@github-actions github-actions bot added the C:x/genutil genutil module issues label May 30, 2022
@tac0turtle
Copy link
Member Author

closing this. I think with the coordination with Tendermint is sufficient enough now

@tac0turtle tac0turtle closed this Jun 1, 2022
@julienrbrt julienrbrt deleted the marko/legacy_p2p branch June 17, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/genutil genutil module issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants