chore: Db linting #12141
Merged
chore: Db linting #12141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…osmos-sdk into linting-math-lib
github-actions
bot
added
C:CLI
C:Keys
|
Apparently that was one of the odd intermittent test failures, and this one is ready to go! |
github-actions
bot
added
C:x/auth
C:x/bank
C:x/crisis
C:x/nft
C:x/slashing
C:x/upgrade
labels
tac0turtle
reviewed
Jun 8, 2022
tac0turtle
reviewed
Jun 8, 2022
|
the diff is complete, so that the secp256k1 folder will show only nolint lines as the difference from |
tac0turtle
approved these changes
Jun 8, 2022
5 tasks
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
* mainly sdk.int to cosmossdk.io/math * staking keys * fumpt * var-naming linter errors and a fumpt * Update CHANGELOG.md * Update .golangci.yml * Update CHANGELOG.md * Update test_helpers.go * Update test_helpers.go * fumpt and lint * this lints the db module, and makes it easier to use. It adds breaking name changes * DBConnection -> Connection * previous commit contained a merge error * Update test_helpers.go * Update test_helpers.go * db renamings * merge master * changelog * DBWriter -> Writer * consistent multistore reciever * standard recievers for multistore v2alpha1 * general cleanup of linting issues * more linter fixes * remove prealloc linter * nolint the secp256k1 import * nolint the secp256k1 package * completenolint resulting in a diff that has only nolints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes breaking changes. Specifically, it renames the Reader, Writer, ReadWriter, and Connection to more human friendly names, and complies with the linter while doing so.
Basically, this PR advances the goals of #12133 by dramatically improving the naming compliance of the cosmos-sdk.
I completed this PR by fixing most linting problems in the cosmos-sdk.
Where possible, I favored solving the underlying issue over using //nolint:*
In many cases, this meant changing the names of things more than I'd normally be comfortable with, to try and move towards standardization.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change