feat: decouple x/slashing from simapp

[atheeshp]

Description

Closes: #12195

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[tac0turtle]

LGTM

[julienrbrt]

LGTM, but there is a few decoupling missing:

• TestBeginBlocker
• TestSlashingMsgs
• TestExportAndInitGenesis
• TestUnJailNotBonded (I think you need to move the test helpers function to testutil/sims and add a changelog)
• TestNewQuerier
• TestWeightedOperations (You can use the weight from testutil/sims)
• WeightedOperations (You can use the weight from testutil/sims)

[codecov]

Codecov Report

Merging #12315 (3286ad8) into main (464fd17) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #12315      +/-   ##
==========================================
- Coverage   65.96%   65.88%   -0.08%     
==========================================
  Files         676      676              
  Lines       71295    71296       +1     
==========================================
- Hits        47028    46976      -52     
- Misses      21627    21690      +63     
+ Partials     2640     2630      -10     

Impacted Files	Coverage Δ
x/slashing/simulation/operations.go	0.00% <0.00%> (-59.10%)	⬇️
x/group/keeper/keeper.go	56.96% <0.00%> (-0.43%)	⬇️
crypto/keys/internal/ecdsa/privkey.go	83.01% <0.00%> (+1.88%)	⬆️

[julienrbrt]

LGTM, just two tests still missing:

• TestNewQuerier
• TestQueryParams

See https://github.com/cosmos/cosmos-sdk/blob/ap/decouple-slashing/x/slashing/keeper/querier_test.go

[atheeshp]

LGTM, just two tests still missing:

• TestNewQuerier
• TestQueryParams

See https://github.com/cosmos/cosmos-sdk/blob/ap/decouple-slashing/x/slashing/keeper/querier_test.go

updated

[julienrbrt]

Discovered while migrating x/staking: The simulation test suite actually do not actually test anything in operation. I have missed the coverage change shown here: #12315 (comment).

Fix incoming...