Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port x/upgrade integration tests to app wiring #12330

Closed
wants to merge 3 commits into from

Conversation

julienrbrt
Copy link
Member

Description

Follow-up of #12312
Closes: #12298


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt marked this pull request as ready for review June 27, 2022 12:05
@julienrbrt julienrbrt requested a review from a team as a code owner June 27, 2022 12:05
@julienrbrt julienrbrt marked this pull request as draft June 27, 2022 12:15
@julienrbrt julienrbrt changed the base branch from main to epic/app-wiring June 29, 2022 13:41
@julienrbrt julienrbrt changed the base branch from epic/app-wiring to main June 29, 2022 15:42
@julienrbrt
Copy link
Member Author

Closing in favor of #12398

@julienrbrt julienrbrt closed this Jun 30, 2022
@julienrbrt julienrbrt deleted the julien/upgrade-app-wiring-2 branch June 30, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

migrate x/upgrade to use app wiring
1 participant