Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: remove app wiring from module docs #12393

Merged
merged 4 commits into from
Jun 30, 2022
Merged

Conversation

julienrbrt
Copy link
Member

Description

Removes the app wiring documentation that was using in the tests. As we move away to use mocks.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #12393 (5e4257a) into main (a32349d) will decrease coverage by 0.00%.
The diff coverage is 86.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12393      +/-   ##
==========================================
- Coverage   65.67%   65.66%   -0.01%     
==========================================
  Files         676      676              
  Lines       71429    71420       -9     
==========================================
- Hits        46911    46900      -11     
- Misses      21878    21886       +8     
+ Partials     2640     2634       -6     
Impacted Files Coverage Δ
x/bank/module.go 62.62% <ø> (ø)
x/gov/keeper/grpc_query.go 76.56% <78.57%> (+0.93%) ⬆️
x/distribution/keeper/grpc_query.go 68.96% <90.00%> (+1.35%) ⬆️
x/staking/keeper/grpc_query.go 60.25% <90.47%> (+1.29%) ⬆️
x/bank/keeper/grpc_query.go 56.12% <100.00%> (ø)
x/feegrant/keeper/grpc_query.go 82.55% <100.00%> (+2.33%) ⬆️
x/distribution/simulation/operations.go 80.74% <0.00%> (-9.63%) ⬇️
... and 2 more

@julienrbrt julienrbrt merged commit 1642dcd into main Jun 30, 2022
@julienrbrt julienrbrt deleted the docs/cleanup-appwiring branch June 30, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants