-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(x/mint): fix sim failure #12459
fix(x/mint): fix sim failure #12459
Conversation
Codecov Report
@@ Coverage Diff @@
## main #12459 +/- ##
==========================================
- Coverage 65.65% 65.62% -0.04%
==========================================
Files 684 683 -1
Lines 71637 71564 -73
==========================================
- Hits 47035 46964 -71
- Misses 21954 21958 +4
+ Partials 2648 2642 -6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We removed x/params from x/mint on purpose and we're going to do this for every module. Instead, I think we need to return an empty slice for RandomizedParams
#12461 should do it I'm not sure how the original PR was green though as the simulation fails |
@@ -40,6 +42,11 @@ | |||
panic(fmt.Sprintf("the x/%s module account has not been set", types.ModuleName)) | |||
} | |||
|
|||
// set KeyTable if it has not already been set | |||
if !paramSpace.HasKeyTable() { | |||
paramSpace = paramSpace.WithKeyTable(types.ParamKeyTable()) |
Check warning
Code scanning / CodeQL
Useless assignment to local variable
I don't think Sims run in PR checks. |
The single seed non-determinism one does. I found the issue and resolved it in my PR 👍 |
Description
This fixes a recently introduced sim failure:
However it also reintroduces the dependency
x/mint -> x/params
which was removed in #12363Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change