Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize store.write #12494

Merged
merged 4 commits into from
Jul 11, 2022
Merged

perf: optimize store.write #12494

merged 4 commits into from
Jul 11, 2022

Conversation

bradyjoestar
Copy link
Contributor

@bradyjoestar bradyjoestar commented Jul 9, 2022

Description

#12493
Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@bradyjoestar bradyjoestar requested a review from a team as a code owner July 9, 2022 06:16
@codecov
Copy link

codecov bot commented Jul 10, 2022

Codecov Report

Merging #12494 (bd778f6) into main (b10fa1d) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head bd778f6 differs from pull request most recent head 119bf14. Consider uploading reports for the commit 119bf14 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12494      +/-   ##
==========================================
- Coverage   65.59%   65.54%   -0.05%     
==========================================
  Files         699      687      -12     
  Lines       72557    71709     -848     
==========================================
- Hits        47592    47000     -592     
+ Misses      22275    22057     -218     
+ Partials     2690     2652      -38     
Impacted Files Coverage Δ
store/cachekv/store.go 79.11% <100.00%> (+0.16%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 81.13% <0.00%> (-1.89%) ⬇️
cosmovisor/cmd/cosmovisor/run.go
cosmovisor/args.go
cosmovisor/cmd/cosmovisor/init.go
cosmovisor/cmd/cosmovisor/help.go
cosmovisor/scanner.go
cosmovisor/logger.go
cosmovisor/cmd/cosmovisor/version.go
... and 5 more

@julienrbrt julienrbrt linked an issue Jul 10, 2022 that may be closed by this pull request
4 tasks
@julienrbrt julienrbrt changed the title optimize store.write perf: optimize store.write Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

optimize store.write in cacheKV
3 participants