Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: auto gas don't work #12589

Closed
wants to merge 2 commits into from

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jul 15, 2022

Solution:

  • allow zero gas in simulation mode

Description

Closes: #12588


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Solution:
- allow zero gas in simulation mode
@yihuang yihuang requested a review from a team as a code owner July 15, 2022 03:59
CHANGELOG.md Outdated Show resolved Hide resolved
@yihuang yihuang changed the base branch from release/v0.46.x to main July 15, 2022 04:03
@yihuang yihuang changed the base branch from main to release/v0.46.x July 15, 2022 04:03
@yihuang
Copy link
Collaborator Author

yihuang commented Jul 15, 2022

opened to main branch first, backport later.

@yihuang yihuang closed this Jul 15, 2022
@yihuang yihuang deleted the release/v0.46.x branch July 15, 2022 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant