Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: auto gas don't work (backport #12590) #12602

Merged
merged 2 commits into from
Jul 17, 2022
Merged

fix: auto gas don't work (backport #12590) #12602

merged 2 commits into from
Jul 17, 2022

Commits on Jul 16, 2022

  1. fix: auto gas don't work (#12590) 

    ## Description

Closes: #12588
Solution:
- allow zero gas in simulation mode
- don't check min-gas-price in simulation mode

Please backport to 0.46.

---

### Author Checklist

*All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.*

I have...

- [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] added `!` to the type prefix if API or client breaking change
- [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting))
- [ ] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)

(cherry picked from commit 0a3c597)

# Conflicts:
#	CHANGELOG.md
    @yihuang @mergify
    yihuang authored and mergify[bot] committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    bcb00d2 View commit details
    Browse the repository at this point in the history

  2. fix conflict

    @julienrbrt
    julienrbrt committed Jul 16, 2022
    Configuration menu
    Copy the full SHA
    e14afe6 View commit details
    Browse the repository at this point in the history