Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: deprecate x/params usage in x/gov #12631

Merged
merged 47 commits into from
Aug 1, 2022
Merged

feat: deprecate x/params usage in x/gov #12631

Show file tree
Hide file tree
Changes from 33 commits
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
1474f19
wip: deprecate x/params usage in x/gov
atheeshp Jul 19, 2022
ec70c2b
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/gov-params
atheeshp Jul 19, 2022
8dc97c5
add migrations
atheeshp Jul 19, 2022
782a7a9
add tests
atheeshp Jul 19, 2022
2328582
fix tests
atheeshp Jul 19, 2022
66d304b
update tests
atheeshp Jul 19, 2022
3497236
remove comments
atheeshp Jul 19, 2022
de9e07e
add genesis tests
atheeshp Jul 20, 2022
1392f53
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/gov-params
atheeshp Jul 20, 2022
f8e8e29
changes
atheeshp Jul 20, 2022
e73d56f
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/gov-params
atheeshp Jul 20, 2022
dd334f5
fix tests
atheeshp Jul 20, 2022
b2420cf
add tests
atheeshp Jul 20, 2022
292a08e
review
atheeshp Jul 20, 2022
1bc5a94
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/gov-params
atheeshp Jul 20, 2022
d656a9f
update changelog
atheeshp Jul 20, 2022
90e5ae4
remove unnecessary code
atheeshp Jul 21, 2022
13205e6
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/gov-params
atheeshp Jul 21, 2022
4cd8271
proto changes
atheeshp Jul 21, 2022
1e50c8b
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/gov-params
atheeshp Jul 21, 2022
1a08268
add deprecate
atheeshp Jul 22, 2022
1130e56
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/gov-params
atheeshp Jul 25, 2022
222a97c
fix test
atheeshp Jul 25, 2022
b778d3a
add deprecation option
atheeshp Jul 25, 2022
e238373
fix tests
atheeshp Jul 25, 2022
9c22c5a
review changes
atheeshp Jul 25, 2022
b9821b3
fix tests
atheeshp Jul 25, 2022
2f50c4a
fix tests
atheeshp Jul 26, 2022
5dd9fb2
review changes
atheeshp Jul 26, 2022
679f35f
fix test
atheeshp Jul 26, 2022
8268ebd
Merge branch 'main' into ap/gov-params
atheeshp Jul 26, 2022
ebf0cb7
add since
atheeshp Jul 26, 2022
9e2fbc7
Merge branch 'ap/gov-params' of github.com:cosmos/cosmos-sdk into ap/…
atheeshp Jul 26, 2022
bc6f7dc
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/gov-params
atheeshp Jul 27, 2022
be26dc7
rename migration packages
atheeshp Jul 27, 2022
2063680
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/gov-params
atheeshp Jul 28, 2022
d1d9aa6
review changes
atheeshp Jul 28, 2022
8d2e954
proto
atheeshp Jul 28, 2022
353cb25
review changes
atheeshp Jul 28, 2022
9e5655b
review changes
atheeshp Jul 28, 2022
47d86c0
review changes
atheeshp Jul 28, 2022
a5400a2
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/gov-params
atheeshp Aug 1, 2022
c8a3a3e
Merge branch 'main' of github.com:cosmos/cosmos-sdk into ap/gov-params
atheeshp Aug 1, 2022
82bdca8
review changes
atheeshp Aug 1, 2022
b46f81e
review changes
atheeshp Aug 1, 2022
45e10ed
Update x/gov/migrations/v3/keys.go
atheeshp Aug 1, 2022
6aed65d
Merge branch 'main' into ap/gov-params
atheeshp Aug 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (x/mint) [#12363](https://github.com/cosmos/cosmos-sdk/pull/12363) Migrate `x/mint` to self-managed parameters and deprecate it's usage of `x/params`.
* (x/distribution) [#12434](https://github.com/cosmos/cosmos-sdk/pull/12434) Migrate `x/distribution` to self-managed parameters and deprecate it's usage of `x/params`.
* (x/crisis) [#12445](https://github.com/cosmos/cosmos-sdk/pull/12445) Migrate `x/crisis` to self-managed parameters and deprecate it's usage of `x/params`.
* (x/gov) [#12631](https://github.com/cosmos/cosmos-sdk/pull/12631) Migrate `x/gov` to self-managed parameters and deprecate it's usage of `x/params`.
atheeshp marked this conversation as resolved.
Show resolved Hide resolved
* (x/staking) [#12409](https://github.com/cosmos/cosmos-sdk/pull/12409) Migrate `x/staking` to self-managed parameters and deprecate it's usage of `x/params`.


Expand All @@ -89,6 +90,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (x/distribution) [#12434](https://github.com/cosmos/cosmos-sdk/pull/12434) `x/distribution` module `SetParams` keeper method definition is now updated to return `error`.
* (x/staking) [#12409](https://github.com/cosmos/cosmos-sdk/pull/12409) `x/staking` module `SetParams` keeper method definition is now updated to return `error`.
* (x/crisis) [#12445](https://github.com/cosmos/cosmos-sdk/pull/12445) `x/crisis` module `SetConstantFee` keeper method definition is now updated to return `error`.
* (x/gov) [#12631](https://github.com/cosmos/cosmos-sdk/pull/12631) `x/gov` module refactored to use `Params` as single struct instead of `DepositParams`, `TallyParams` & `VotingParams`.

### CLI Breaking Changes

Expand Down
166 changes: 136 additions & 30 deletions api/cosmos/gov/v1/genesis.pulsar.go
View file
Open in desktop

Large diffs are not rendered by default.

Loading