Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add cosmos_proto implements (backport #12639) #12664

Merged
merged 1 commit into from
Jul 21, 2022
Merged

fix: add cosmos_proto implements (backport #12639) #12664

merged 1 commit into from
Jul 21, 2022

Commits on Jul 21, 2022

  1. fix: add cosmos_proto implements (#12639) 

    It seems that we're missing the `cosmos_proto.implements_interface` on many proposal messages/structs

this is a draft to discuss adding options in protos for better codegen tooling. It seems that the following messages/structs are meant to implement `Content`:

```
option (cosmos_proto.implements_interface) = "cosmos.gov.v1beta1.Content"
```

Would this be a breaking change? Happy to improve/amend this so it's mergeable.

related issue: #12640

(cherry picked from commit 64674ba)
    @pyramation @mergify
    pyramation authored and mergify[bot] committed Jul 21, 2022
    Configuration menu
    Copy the full SHA
    2a3678d View commit details
    Browse the repository at this point in the history