Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove cosmossdk.io/api module from v0.46.x #12719

Merged
merged 2 commits into from
Jul 26, 2022

Conversation

aleem1314
Copy link
Contributor

@aleem1314 aleem1314 commented Jul 25, 2022

Description

v0.46 is not using cosmossdk.io/api. Left over from #12353.

We are facing the following issue while updating to SDK v0.46.

panic: proto: file "cosmos/base/query/v1beta1/pagination.proto" is already registered
        previously from: "cosmossdk.io/api/cosmos/base/query/v1beta1"
        currently from:  "github.com/cosmos/cosmos-sdk/api/cosmos/base/query/v1beta1"
See https://developers.google.com/protocol-buffers/docs/reference/go/faq#namespace-conflict

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Jul 25, 2022
@aleem1314 aleem1314 marked this pull request as ready for review July 25, 2022 16:34
@aleem1314 aleem1314 requested a review from a team as a code owner July 25, 2022 16:34
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, thanks @aleem1314 !

@alexanderbez
Copy link
Contributor

What's up with TestIntegrationTestSuite/TestGetTxEvents_GRPCGateway failing?

@tac0turtle tac0turtle merged commit a69a77b into release/v0.46.x Jul 26, 2022
@tac0turtle tac0turtle deleted the aleem/remove-sdk-api-module branch July 26, 2022 06:14
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants