Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace app wiring yaml config by go #12757

Merged
merged 10 commits into from
Jul 29, 2022
Merged

refactor: replace app wiring yaml config by go #12757

merged 10 commits into from
Jul 29, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Jul 28, 2022 •
edited
Loading

Description

  • This PR converts the remaining app.yaml to app_config.go.
  • It uses SimApp in e2e tests instead of AppConfig.
  • Removes unused AppConfig.

Ref: #11899, #12398

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner July 28, 2022 07:30
@julienrbrt julienrbrt marked this pull request as draft July 28, 2022 07:34
@julienrbrt julienrbrt marked this pull request as ready for review July 28, 2022 12:00
@julienrbrt julienrbrt marked this pull request as draft July 28, 2022 13:07
@julienrbrt julienrbrt changed the title refactor: end-to-end tests should use simapp refactor: use app wiring in e2e tests Jul 28, 2022
@julienrbrt julienrbrt changed the title refactor: use app wiring in e2e tests refactor: replace app.yaml by app_config.go Jul 28, 2022
@julienrbrt julienrbrt changed the title refactor: replace app.yaml by app_config.go refactor: replace app wiring yaml config to go Jul 28, 2022
@julienrbrt julienrbrt changed the title refactor: replace app wiring yaml config to go refactor: use app wiring in e2e test and replace yaml config by go Jul 28, 2022
@julienrbrt julienrbrt changed the title refactor: use app wiring in e2e test and replace yaml config by go refactor: replace app wiring yaml config by go Jul 28, 2022
@julienrbrt julienrbrt marked this pull request as ready for review July 28, 2022 17:04
kocubinski
kocubinski approved these changes Jul 28, 2022
View reviewed changes
Copy link
Member

@kocubinski kocubinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to be consistent in our end to end tests.

facundomedica
facundomedica approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@facundomedica facundomedica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@facundomedica facundomedica merged commit dc95e33 into main Jul 29, 2022
@facundomedica facundomedica deleted the julien/e2e-simapp branch July 29, 2022 19:39
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
@julienrbrt
refactor: replace app wiring yaml config by go (cosmos#12757)
21dfe02 
* refactor: end-to-end tests should use simapp

* updates

* updates

* remove unecessary AppWiring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kocubinski kocubinski kocubinski approved these changes

@facundomedica facundomedica facundomedica approved these changes

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
C:x/auth C:x/authz C:x/capability C:x/distribution distribution module related C:x/evidence C:x/feegrant C:x/group C:x/mint C:x/nft C:x/params C:x/slashing C:x/upgrade
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julienrbrt @kocubinski @facundomedica