Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simulation failures #12858

Merged
merged 5 commits into from
Aug 8, 2022
Merged

fix: simulation failures #12858

merged 5 commits into from
Aug 8, 2022

Conversation

kocubinski
Copy link
Member

Description

Closes: #12806


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

- handle err in staking/keeper/InitGenesis SetParams
- handle Params type text render in staking
@kocubinski kocubinski requested a review from a team as a code owner August 8, 2022 18:15
@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #12858 (4878c05) into main (e2d6cbd) will decrease coverage by 0.02%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12858      +/-   ##
==========================================
- Coverage   56.25%   56.22%   -0.03%     
==========================================
  Files         648      644       -4     
  Lines       55031    54933      -98     
==========================================
- Hits        30956    30886      -70     
+ Misses      21581    21557      -24     
+ Partials     2494     2490       -4     
Impacted Files Coverage Δ
x/staking/keeper/genesis.go 53.38% <0.00%> (-1.17%) ⬇️
x/staking/simulation/decoder.go 85.71% <0.00%> (-14.29%) ⬇️
store/types/utils.go 100.00% <100.00%> (ø)
x/gov/simulation/operations.go 84.18% <100.00%> (ø)
tx/textual/valuerenderer/valuerenderer.go
tx/textual/valuerenderer/int.go
tx/textual/valuerenderer/bytes.go
tx/textual/valuerenderer/dec.go
x/group/keeper/keeper.go 56.29% <0.00%> (+0.39%) ⬆️
crypto/keys/internal/ecdsa/privkey.go 83.01% <0.00%> (+1.88%) ⬆️

@alexanderbez alexanderbez merged commit 8f9a88c into main Aug 8, 2022
@alexanderbez alexanderbez deleted the kocubinski/sims-store-fix branch August 8, 2022 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sims are failing on main
3 participants