Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Upstream to evaluate Liquid staking #12917

Closed
wants to merge 4 commits into from
Closed

WIP: Upstream to evaluate Liquid staking #12917

wants to merge 4 commits into from

Conversation

tac0turtle
Copy link
Member

Description

Opening this work upstream to evaluate how to best upstream the work

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle changed the base branch from main to release/v0.46.x August 12, 2022 15:39
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 12, 2022
View reviewed changes
x/staking/keeper/msg_server.go

// calculate the ratio between shares and redeem amount
// moduleAccountTotalDelegation * redeemAmount / totalIssue
delegation, found := k.GetDelegation(ctx, record.GetModuleAddress(), valAddr)

Check warning

Code scanning / CodeQL

Useless assignment to local variable

This definition of found is never used.
@tac0turtle tac0turtle mentioned this pull request Aug 29, 2022
Closed
4 tasks
@tac0turtle
Copy link
Member Author

closing in favour of #13122

@tac0turtle tac0turtle closed this Sep 1, 2022
@tac0turtle tac0turtle reopened this Sep 1, 2022
@tac0turtle
Copy link
Member Author

wrong PR

@zmanian zmanian mentioned this pull request Sep 12, 2022
Merged
@tac0turtle tac0turtle closed this Oct 6, 2022
@tac0turtle tac0turtle deleted the liquid_staking_2 branch April 6, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C:CLI C:Simulations C:x/distribution distribution module related C:x/slashing C:x/staking
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tac0turtle