Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: downgrade to tendermint v0.34.x #12958

Merged
merged 19 commits into from
Aug 20, 2022
Merged

chore: downgrade to tendermint v0.34.x #12958

merged 19 commits into from
Aug 20, 2022

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Aug 18, 2022

Description

Downgrade to tendermind v0.34.x as 0.35 is discontinued.
Based on #12221 and #12509.

The rosetta build is failing but I cannot run make rosetta-data (ref #12772)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

testutil/network/util.go Fixed Show fixed Hide fixed
@github-actions github-actions bot added the C:orm label Aug 18, 2022
@julienrbrt julienrbrt marked this pull request as ready for review August 18, 2022 15:28
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #12958 (9e2cca7) into main (4fe7797) will decrease coverage by 0.25%.
The diff coverage is 60.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12958      +/-   ##
==========================================
- Coverage   55.87%   55.62%   -0.26%     
==========================================
  Files         646      651       +5     
  Lines       54895    55037     +142     
==========================================
- Hits        30675    30614      -61     
- Misses      21762    21953     +191     
- Partials     2458     2470      +12     
Impacted Files Coverage Δ
baseapp/abci.go 64.09% <0.00%> (-0.33%) ⬇️
client/flags/flags.go 19.35% <0.00%> (-0.32%) ⬇️
client/rpc/status.go 66.66% <ø> (ø)
client/utils.go 34.92% <0.00%> (ø)
server/rosetta/client_online.go 1.35% <0.00%> (ø)
server/swagger.go 0.00% <0.00%> (ø)
simapp/app.go 82.66% <0.00%> (+3.55%) ⬆️
types/result.go 76.74% <ø> (ø)
x/auth/tx/query.go 0.00% <ø> (ø)
x/auth/tx/service.go 0.00% <ø> (ø)
... and 50 more

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: likhita-809 <78951027+likhita-809@users.noreply.github.com>
CHANGELOG.md Show resolved Hide resolved
@julienrbrt julienrbrt merged commit 1dee068 into main Aug 20, 2022
@julienrbrt julienrbrt deleted the julien/tm-034 branch August 20, 2022 00:33
Manav-Aggarwal pushed a commit to celestiaorg/cosmos-sdk that referenced this pull request Aug 24, 2022
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants