-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(codec): MarshalInterface should err when UnmarshalInterface will fail #12964
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nit: changelog :)
Thank you so much for making this happen 💪 |
…mos-sdk into kocubinski/marshall-iface-err
Codecov Report
@@ Coverage Diff @@
## main #12964 +/- ##
==========================================
+ Coverage 55.54% 55.56% +0.01%
==========================================
Files 647 647
Lines 54901 54916 +15
==========================================
+ Hits 30496 30515 +19
+ Misses 21941 21937 -4
Partials 2464 2464
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
Closes: #12894
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change