Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codec): MarshalInterface should err when UnmarshalInterface will fail #12964

Merged
merged 13 commits into from
Aug 19, 2022

Conversation

kocubinski
Copy link
Member

@kocubinski kocubinski commented Aug 18, 2022

Description

Closes: #12894


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:CLI label Aug 18, 2022
@kocubinski kocubinski marked this pull request as ready for review August 18, 2022 20:11
@kocubinski kocubinski requested a review from a team as a code owner August 18, 2022 20:11
@kocubinski kocubinski changed the title fix(codec): MarshallInterface should err when UnmarshalInterface will fail fix(codec): MarshalInterface should err when UnmarshalInterface will fail Aug 18, 2022
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nit: changelog :)

@ValarDragon
Copy link
Contributor

Thank you so much for making this happen 💪

@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #12964 (a45c399) into main (f430528) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #12964      +/-   ##
==========================================
+ Coverage   55.54%   55.56%   +0.01%     
==========================================
  Files         647      647              
  Lines       54901    54916      +15     
==========================================
+ Hits        30496    30515      +19     
+ Misses      21941    21937       -4     
  Partials     2464     2464              
Impacted Files Coverage Δ
codec/types/interface_registry.go 51.11% <20.00%> (-2.86%) ⬇️
client/grpc_query.go 15.38% <100.00%> (+15.38%) ⬆️
codec/proto_codec.go 62.41% <100.00%> (+1.09%) ⬆️

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kocubinski kocubinski added the A:automerge Automatically merge PR once all prerequisites pass. label Aug 19, 2022
@mergify mergify bot merged commit 28a7e33 into main Aug 19, 2022
@mergify mergify bot deleted the kocubinski/marshall-iface-err branch August 19, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proto: Make marshal interface return error if interface not registered
4 participants