Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli/api): add validator distribution info grpc gateway get endpoint #13144

Merged
merged 10 commits into from
Sep 5, 2022
Merged

feat(cli/api): add validator distribution info grpc gateway get endpoint #13144

merged 10 commits into from
Sep 5, 2022

Conversation

gsk967
Copy link
Contributor

@gsk967 gsk967 commented Sep 3, 2022

Description

Closes: #13077

added back deprecated get endpoint of validator distribution info to grpc gateway get endpoint

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

gsk967 and others added 3 commits September 3, 2022 11:21
@gsk967
feat: add distribution info grpc gateway get endpoint
3df9406
@likhita-809 @gsk967
refactor(evidence): CLI tests using Tendermint Mock (#13056)
8b525eb 
* wip

* fix something

* remove test case from tx test

* fix test

* add build tags to cli test

* use require instead of assert

* add cli tests
@gsk967
chore: fix the merge conflicts
f4bcbb3
@github-actions github-actions bot added C:CLI C:x/distribution distribution module related labels Sep 3, 2022
@codecov
Copy link

codecov bot commented Sep 3, 2022 •
edited
Loading

Codecov Report

Merging #13144 (8e65f98) into main (8579bdd) will decrease coverage by 0.06%.
The diff coverage is 0.00%.

❗ Current head 8e65f98 differs from pull request most recent head aca102d. Consider uploading reports for the commit aca102d to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13144      +/-   ##
==========================================
- Coverage   53.22%   53.15%   -0.07%     
==========================================
  Files         645      645              
  Lines       55188    55258      +70     
==========================================
- Hits        29374    29373       -1     
- Misses      23468    23540      +72     
+ Partials     2346     2345       -1
Impacted Files Coverage Δ
x/distribution/client/cli/query.go 0.00% <0.00%> (ø)
x/distribution/keeper/grpc_query.go 0.00% <0.00%> (ø)
x/group/keeper/keeper.go 56.25% <0.00%> (-0.40%) ⬇️

@gsk967 gsk967 marked this pull request as ready for review September 3, 2022 06:17
@gsk967 gsk967 requested a review from a team as a code owner September 3, 2022 06:17
@gsk967 gsk967 requested a review from alexanderbez September 5, 2022 06:11
@alexanderbez
Copy link
Contributor

LGTM! We need to add a changelog entry too under Features or Improvements

@alexanderbez alexanderbez requested a review from a team September 5, 2022 14:04
tac0turtle
tac0turtle approved these changes Sep 5, 2022
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just missing a changeling entry

@gsk967
Copy link
Contributor Author

gsk967 commented Sep 5, 2022

@marbar3778 @alexanderbez updated the changelog

@anilcse anilcse added the A:automerge Automatically merge PR once all prerequisites pass. label Sep 5, 2022
@alexanderbez alexanderbez enabled auto-merge (squash) September 5, 2022 14:35
@alexanderbez alexanderbez merged commit 65fff07 into cosmos:main Sep 5, 2022
GAtom22 pushed a commit to evmos/cosmos-sdk that referenced this pull request Feb 23, 2023
@gsk967 @GAtom22
feat(cli/api): add validator distribution info grpc gateway get endpo…
d8124f7 
…int (cosmos#13144)
GAtom22 added a commit to evmos/cosmos-sdk that referenced this pull request Feb 23, 2023
@GAtom22 @gsk967
feat(cli/api): add validator distribution info grpc gateway get endpo…
4c524a0 
…inint (cosmos#13144) (#12)

Co-authored-by: Sai Kumar <17549398+gsk967@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anilcse anilcse anilcse left review comments

@tac0turtle tac0turtle tac0turtle approved these changes

@alexanderbez alexanderbez alexanderbez approved these changes

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:x/distribution distribution module related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add grpc gateway get endpoint for validator distribution information
5 participants
@gsk967 @alexanderbez @anilcse @tac0turtle @likhita-809