fix!: Fix gov amino codec #13196
Merged
fix!: Fix gov amino codec #13196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:Simulations
C:x/auth
C:x/authz
C:x/bank
C:x/crisis
C:x/distribution
amaury1093
commented
Sep 8, 2022
| }, | ||
| { | ||
| "MsgSend", []sdk.Msg{banktypes.NewMsgSend(addrs[0], addrs[0], sdk.NewCoins())}, | ||
| fmt.Sprintf(`{"type":"cosmos-sdk/v1/MsgSubmitProposal","value":{"initial_deposit":[],"messages":[{"type":"cosmos-sdk/MsgSend","value":{"amount":[],"from_address":"%s","to_address":"%s"}}]}}`, addrs[0], addrs[0]), |
There was a problem hiding this comment.
This newly added test case fails on main. Main passes with the following string:
{"type":"cosmos-sdk/v1/MsgSubmitProposal","value":{"initial_deposit":[],"messages":[{"amount":[],"from_address":"%s","to_address":"%s"}]}}
which is incorrect
Codecov Report
@@ Coverage Diff @@
## main #13196 +/- ##
==========================================
+ Coverage 53.63% 53.66% +0.03%
==========================================
Files 647 647
Lines 55194 55199 +5
==========================================
+ Hits 29601 29624 +23
+ Misses 23219 23200 -19
- Partials 2374 2375 +1
|
tac0turtle
approved these changes
Sep 8, 2022
drop amino support. More seriously though, I think Riccardo also had some thoughts about this, and this was the best solution we came up with. |
Yup, there are no other solutions to solve this unless we drop entirely the support for Amino |
19 tasks
4 tasks
19 tasks
3 tasks
11 tasks
|
@Mergifyio backport release/v0.46.x |
mergify bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
* fix!: Fix gov amino codec * changelog (cherry picked from commit d9972c4) # Conflicts: # CHANGELOG.md # x/distribution/types/codec.go # x/gov/simulation/operations_test.go # x/gov/types/v1/msgs.go # x/gov/types/v1/msgs_test.go # x/mint/types/codec.go # x/upgrade/types/codec.go
✅ Backports have been created
|
19 tasks
ryanchristo
pushed a commit
to regen-network/cosmos-sdk
that referenced
this pull request
Dec 14, 2022
* fix!: Fix gov amino codec * changelog
clevinson
pushed a commit
to regen-network/cosmos-sdk
that referenced
this pull request
Dec 15, 2022
* fix!: Fix gov amino codec * changelog
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a bug when using amino-json with MsgSubmitProposal. Same as with authz, we need to register gov's ModuleCdc with every other module's
RegisterLegacyAmino. We forgot to do that in v0.46 unfortunately.This results in a nested level of fields being cut-off:
Notice in the
messagesarray, there's a nested level oftypeandlevelmissing. This makes the Ledger<>CosmJS integration impossible.The proposed solution is the same fix as for authz, i.e. in every module, register their msgs with the gov's ModuleCdc. To read more, you can read Simon's article about the topic.
cc'ing:
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change