Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): Bump cosmossdk.io/api from v0.1.0-alpha9 to v0.2.0 #13206

Merged
merged 7 commits into from
Sep 8, 2022

Conversation

julienrbrt
Copy link
Member

Description

Follow-up of #13070


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

go.mod Outdated Show resolved Hide resolved
@julienrbrt julienrbrt enabled auto-merge (squash) September 8, 2022 19:03
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #13206 (9326aa1) into main (4fe7797) will decrease coverage by 2.21%.
The diff coverage is 42.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13206      +/-   ##
==========================================
- Coverage   55.87%   53.66%   -2.22%     
==========================================
  Files         646      647       +1     
  Lines       54895    55199     +304     
==========================================
- Hits        30675    29623    -1052     
- Misses      21762    23202    +1440     
+ Partials     2458     2374      -84     
Impacted Files Coverage Δ
baseapp/abci.go 67.01% <0.00%> (+2.59%) ⬆️
baseapp/baseapp.go 77.93% <ø> (+1.06%) ⬆️
baseapp/grpcrouter.go 90.00% <ø> (ø)
baseapp/grpcrouter_helpers.go 25.00% <ø> (ø)
baseapp/grpcserver.go 1.72% <ø> (ø)
baseapp/msg_service_router.go 85.29% <ø> (+4.41%) ⬆️
baseapp/options.go 69.23% <ø> (+0.71%) ⬆️
client/cmd.go 57.73% <0.00%> (ø)
client/context.go 54.49% <0.00%> (-1.79%) ⬇️
client/flags/flags.go 19.35% <0.00%> (-0.32%) ⬇️
... and 185 more

@julienrbrt julienrbrt added dependencies Pull requests that update a dependency file A:automerge Automatically merge PR once all prerequisites pass. labels Sep 8, 2022
@aaronc
Copy link
Member

aaronc commented Sep 8, 2022

can we just tag api as v0.2.0 so we don't need the replace?

@julienrbrt
Copy link
Member Author

can we just tag api as v0.2.0 so we don't need the replace?

Sure!

@julienrbrt julienrbrt marked this pull request as draft September 8, 2022 20:01
auto-merge was automatically disabled September 8, 2022 20:01

Pull request was converted to draft

@julienrbrt julienrbrt changed the title build(deps): Bump cosmossdk.io/api from v0.1.0-alpha9 to v0.1.0-alpha10 build(deps): Bump cosmossdk.io/api from v0.1.0-alpha9 to v0.2.0-alpha.1 Sep 8, 2022
@aaronc
Copy link
Member

aaronc commented Sep 8, 2022

do we need alpha on api at all if it's v0.x?

@julienrbrt julienrbrt marked this pull request as ready for review September 8, 2022 20:07
@julienrbrt julienrbrt changed the title build(deps): Bump cosmossdk.io/api from v0.1.0-alpha9 to v0.2.0-alpha.1 build(deps): Bump cosmossdk.io/api from v0.1.0-alpha9 to v0.2.0 Sep 8, 2022
@julienrbrt julienrbrt marked this pull request as draft September 8, 2022 20:10
@julienrbrt
Copy link
Member Author

do we need alpha on api at all if it's v0.x?

Good point!

@julienrbrt julienrbrt marked this pull request as ready for review September 8, 2022 20:12
@julienrbrt julienrbrt enabled auto-merge (squash) September 8, 2022 20:24
@julienrbrt julienrbrt merged commit 84d4bf5 into main Sep 8, 2022
@julienrbrt julienrbrt deleted the julien/update-api branch September 8, 2022 20:36
Wryhder pushed a commit to Wryhder/cosmos-sdk that referenced this pull request Oct 26, 2022
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:CLI C:orm dependencies Pull requests that update a dependency file Type: Build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants