refactor: Remove storev2alpha1

[faddat]

Description

This code seems to be unused and we'll have less work to do with it removed.

• removes storev2alpha1
• corrects changelog entry from refactor: remove db #13370

NB: if I am wrong about this, do not merge

---

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

• included the correct type prefix in the PR title
• added ! to the type prefix if API or client breaking change
• targeted the correct branch (see PR Targeting)
• provided a link to the relevant issue or specification
• followed the guidelines for building modules
• included the necessary unit and integration tests
• added a changelog entry to CHANGELOG.md
• included comments for documenting Go code
• updated the relevant documentation or specification
• reviewed "Files changed" and left comments if necessary
• confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

• confirmed the correct type prefix in the PR title
• confirmed ! in the type prefix if API or client breaking change
• confirmed all author checklist items have been addressed
• reviewed state machine logic
• reviewed API design and naming
• reviewed documentation is accurate
• reviewed tests and test coverage
• manually tested (if applicable)

[codecov]

Codecov Report

Merging #13371 (9256568) into main (4fe7797) will decrease coverage by 1.57%.
The diff coverage is 28.00%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #13371      +/-   ##
==========================================
- Coverage   55.87%   54.30%   -1.58%     
==========================================
  Files         646      639       -7     
  Lines       54895    54585     -310     
==========================================
- Hits        30675    29644    -1031     
- Misses      21762    22561     +799     
+ Partials     2458     2380      -78     

Impacted Files	Coverage Δ
baseapp/grpcrouter.go	90.00% <ø> (ø)
baseapp/grpcrouter_helpers.go	25.00% <ø> (ø)
baseapp/grpcserver.go	1.72% <ø> (ø)
baseapp/msg_service_router.go	85.29% <ø> (+4.41%)	⬆️
baseapp/options.go	67.92% <0.00%> (-0.60%)	⬇️
client/broadcast.go	54.54% <ø> (+2.99%)	⬆️
client/cmd.go	57.73% <ø> (ø)
client/config/toml.go	55.55% <ø> (ø)
client/context.go	54.49% <ø> (-1.79%)	⬇️
client/flags/flags.go	19.35% <ø> (-0.32%)	⬇️
... and 247 more

[julienrbrt]

AFAIK, there are discussions of moving it to a feature branch, so this PR might be needed.

[faddat]

Would make it easier to complete work on iavl and cosmos-db integration

[faddat]

@julienrbrt -- any ideas about this e2e test?

[tac0turtle]

AFAIK, there are discussions of moving it to a feature branch, so this PR might be needed.

https://github.com/cosmos/cosmos-sdk/tree/store/v2 features branch is already live

[faddat]

Landing in Dallas-- hope to meet you both soon!

❤️

[faddat]

I'll fix the changelog entry for the other one, here. Sorry bout that!

[julienrbrt]

@julienrbrt -- any ideas about this e2e test?

That test iirc is flaky. Retrying should suffice.

Due to #13370, you'll want to remove these two lines: I had to do it before, so it isn't needed anymore.

• cosmos-sdk/contrib/images/simd-dlv/Dockerfile

  Line 8 in c1ec645

  COPY db/go.mod db/go.sum /work/db/

• cosmos-sdk/contrib/images/simd-env/Dockerfile

  Line 7 in c1ec645

  COPY db/go.mod db/go.sum /work/db/

[faddat]

Cool! I'll take care of it as soon as I'm waiting for next flight.

[faddat]

dallas -> miami