Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump go minimum version to go 1.19 #13397

Merged
merged 5 commits into from
Sep 27, 2022
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Sep 26, 2022

Description

ref: #13373

cc @mmsqe


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner September 26, 2022 23:24
@github-actions github-actions bot added C:CLI C:Cosmovisor Issues and PR related to Cosmovisor C:orm C:Rosetta Issues and PR related to Rosetta C:Store Type: Build Type: CI labels Sep 26, 2022
@julienrbrt julienrbrt changed the title deps: bump go minimum version to go 1.19 build(deps): bump go minimum version to go 1.19 Sep 26, 2022
@julienrbrt julienrbrt marked this pull request as draft September 27, 2022 00:03
snapshots/types/format.go Outdated Show resolved Hide resolved
@julienrbrt julienrbrt marked this pull request as ready for review September 27, 2022 00:07
@yihuang
Copy link
Collaborator

yihuang commented Sep 27, 2022

Why not fix the double close at the caller side, and bump format version, then all golang versions should work with the new format.

@julienrbrt
Copy link
Member Author

Waiting for #13400 to rebase.

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #13397 (cfcb4f0) into main (53519ea) will decrease coverage by 0.05%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13397      +/-   ##
==========================================
- Coverage   54.33%   54.28%   -0.06%     
==========================================
  Files         640      637       -3     
  Lines       54816    54601     -215     
==========================================
- Hits        29787    29641     -146     
+ Misses      22630    22580      -50     
+ Partials     2399     2380      -19     
Impacted Files Coverage Δ
x/staking/simulation/operations.go 74.54% <0.00%> (-1.38%) ⬇️
store/tools/ics23/iavl/create.go
store/tools/ics23/iavl/convert.go
store/tools/ics23/smt/create.go
crypto/keys/secp256k1/internal/secp256k1/curve.go 23.62% <0.00%> (+6.59%) ⬆️

@julienrbrt julienrbrt merged commit 9bae8a8 into main Sep 27, 2022
@julienrbrt julienrbrt deleted the julien/bump-go branch September 27, 2022 19:02
ryanchristo pushed a commit to regen-network/cosmos-sdk that referenced this pull request Dec 14, 2022
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI C:Cosmovisor Issues and PR related to Cosmovisor C:orm C:Rosetta Issues and PR related to Rosetta C:Store Type: Build Type: CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants