Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch gometalinter to stable #1341

Merged
merged 4 commits into from
Jun 22, 2018
Merged

Switch gometalinter to stable #1341

merged 4 commits into from
Jun 22, 2018

Conversation

ValarDragon
Copy link
Contributor

Closes #1338
This switches gometalinter to gometalinter.v2. This also deletes the unused code with go-vendor install, as we can now install things via go get, instead of dep. This also removes the unused make install command in tools.

  • Updated all relevant documentation in docs - I don't know of any documentation for what linter we use?
  • Updated all code comments where relevant - n/a
  • Wrote tests - n/a
  • Updated CHANGELOG.md
  • Updated Gaia/Examples - n/a
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@ValarDragon
Copy link
Contributor Author

I believe that test_cover failing unrelated to my code here. I did not change any of the circle CI code for test_cover, or make install in the main Makefile, which is what it calls. I'll make an issue for this.

@codecov
Copy link

codecov bot commented Jun 22, 2018

Codecov Report

Merging #1341 into develop will increase coverage by 1.49%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1341      +/-   ##
===========================================
+ Coverage    64.77%   66.27%   +1.49%     
===========================================
  Files          112       98      -14     
  Lines         6271     5390     -881     
===========================================
- Hits          4062     3572     -490     
+ Misses        1985     1609     -376     
+ Partials       224      209      -15

Copy link
Contributor

@cwgoes cwgoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ACK

@cwgoes cwgoes merged commit 15bba91 into develop Jun 22, 2018
@cwgoes cwgoes deleted the dev/stable_gometalinter branch June 22, 2018 20:08
adrianbrink pushed a commit that referenced this pull request Jul 2, 2018
* Switch gometalinter to stable
* Delete empty folder
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants