Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: cleanup simapp #13757

Merged
merged 3 commits into from
Nov 4, 2022
Merged

refactor: cleanup simapp #13757

merged 3 commits into from
Nov 4, 2022

Conversation

julienrbrt
Copy link
Member

Description

As simapp must not be imported and helpers have been extracted to testutil/sims`
Removes unnecessary helpers from SimApp.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner November 4, 2022 06:58
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This not used anymore?

@julienrbrt julienrbrt marked this pull request as draft November 4, 2022 07:13
@julienrbrt julienrbrt marked this pull request as ready for review November 4, 2022 07:17
@julienrbrt
Copy link
Member Author

This not used anymore?

A few isn't. They can be replaced with helpers from using keepers directly.

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #13757 (ad8db04) into main (08be7ee) will decrease coverage by 0.21%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #13757      +/-   ##
==========================================
- Coverage   56.15%   55.93%   -0.22%     
==========================================
  Files         655      656       +1     
  Lines       56195    57141     +946     
==========================================
+ Hits        31555    31961     +406     
- Misses      22064    22598     +534     
- Partials     2576     2582       +6     
Impacted Files Coverage Δ
simapp/test_helpers.go 34.30% <ø> (ø)
testutil/sims/app_helpers.go 0.00% <ø> (ø)
tx/textual/valuerenderer/duration.go
tx/textual/valuerenderer/coins.go
tx/textual/valuerenderer/string.go
tx/textual/valuerenderer/valuerenderer.go
tx/textual/valuerenderer/dec.go
tx/textual/valuerenderer/int.go
tx/textual/valuerenderer/bytes.go
tx/textual/valuerenderer/timestamp.go
... and 12 more

@julienrbrt julienrbrt merged commit 5a94358 into main Nov 4, 2022
@julienrbrt julienrbrt deleted the julien/cleanup-simapp branch November 4, 2022 07:51
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants