Merge ledger code into Cwgoes/ledger integration #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cli improvements
Shorter recovery seed
* Optimized ReverseBytes to: a) Minimally allocate --> 60.0% reduction in the number of allocations b) Only walk halfway the length of the string thus performing byte swaps from left to right. Improves the performance as well. Complexity is O(n/2) instead of O(n) which is still O(n) but benchmarks show the new time is in deed 1/2 of the original time. * Added unit tests and some common cases to ensure correctness. * Benchmark shoot out results: ```shell name old time/op new time/op delta ReverseBytes-4 554ns ± 4% 242ns ± 3% -56.20% (p=0.000 n=10+10) name old alloc/op new alloc/op delta ReverseBytes-4 208B ± 0% 114B ± 0% -45.19% (p=0.000 n=10+10) name old allocs/op new allocs/op delta ReverseBytes-4 10.0 ± 0% 4.0 ± 0% -60.00% (p=0.000 n=10+10) ```
hd: optimize ReverseBytes + add tests
Add a godoc reference to delegate indexing and references to that service, thus keeping our library and usages upto date, instead of relying on generated markdown that goes stale especially for changing API signatures, and becomes tedious where someone has to remember to always regenerate the README markdown and then commit it. Fixes cosmos#24
README: add godoc instead of tedious MD regeneration
* Update testnet validator instructions * Address PR comments
…g parameter * Refactor Complete Setup to not take in a testing parameter * Update changelog
* show how to edit validator description * teach about keybase sig * add dash * add more dashes * talk about logos for validators
* added tx hash * changelog
* Merge pull request cosmos#1254: add prefixstore and lib refactor add prefixstore refactor lib fix test fix linter in progress in progress add test for prefixstore add KVStoreGetter, PrefixStoreGetter move PrefixStoreGetter to types/ add tests KVStore.Prefix(string) -> KVStore.Prefix([]byte) fix mock apply requests pass lint, add test apply requests * Remove unnecessarily 'valid' boolean
* Started work on multiple msgs, types and x/auth tests pass * Fix issues in x, examples, and baseapp * Added baseapp tests for multiple msgs * Documentation fixes * Fix baseapp tests with sdk.Int * Modify test * Transaction handling is now atomic * Fix test comment * Minor doc fixes and code cleanup * Added baseapp result changes * Use address in validator update accumulation * Started work on multiple msgs, types and x/auth tests pass * Fix issues in x, examples, and baseapp * Added baseapp tests for multiple msgs * Documentation fixes * Fix baseapp tests with sdk.Int * Modify test * Transaction handling is now atomic * Fix test comment * Minor doc fixes and code cleanup * Added baseapp result changes * Use address in validator update accumulation * Added ante tests for multisigner * Remove validatorUpdates from tx result * Better error logs * Put Memo in StdSignBytes and formatting * Updated changelog
# Conflicts: # client/context/helpers.go # x/auth/stdtx_test.go # x/ibc/app_test.go
- working gopk.toml (latest IAVL/tmlibs/amino combo) - add linux headers to Dockerfile - new import paths for consolidated repos (abci & crypto)
- new import paths for consolidated repos (abci & crypto)
- new import paths for consolidated repos (abci & crypto)
…gration # Conflicts: # .circleci/config.yml # .gitignore
This reverts commit 7ebc7c0. # Conflicts: # Gopkg.toml # Makefile
This reverts commit a589e0e.
This reverts commit 64c1b90.
This reverts commit 7ebc7c0.
- Move keys and ledger files - update some imports
- update imports - catch up with changes due to fundraiser compatibility (english only) -
- fix more tests - update more imports - update to new API
liamsi
force-pushed
the
cwgoes/ledger-integration
branch
from
aba712a
to
a8ca117
Compare
liamsi
force-pushed
the
cwgoes/ledger-integration
branch
from
a8ca117
to
03c69ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@cwgoes this builds on top of your PR #931 PTAL
It still needs some work but contains a bunch of changes (including the ledger integration and some updated deps) that should save you some time.
One step further to tendermint/tendermint#1309 / tendermint/go-crypto#143 (comment)