-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: state listener observe writes at wrong time (backport #13516) #14138
Merged
tac0turtle
merged 8 commits into
release/v0.46.x
from
mergify/bp/release/v0.46.x/pr-13516
Dec 6, 2022
Merged
fix: state listener observe writes at wrong time (backport #13516) #14138
tac0turtle
merged 8 commits into
release/v0.46.x
from
mergify/bp/release/v0.46.x/pr-13516
Dec 6, 2022
Commits on Dec 2, 2022
-
fix: state listener observe writes at wrong time (#13516)
* fix: state listener observe writes at wrong time Closes: #13457 Currently state listener is notified when the cache store write, which happens in commit event only, which breaks the current design. The solution (as discussed in the issue) is to listen state writes on rootmulti store only. It also changes the file streamer to output single data file for the writes in the whole block, since we can't distinguish writes from different stage of abci events. It adds new config items for file streamer: - streamers.file.output-metadata - streamers.file.stop-node-on-error - streamers.file.fsync * synchronous abci call, and format doc * fix comment * update file streamer readme and fix typos * typo * fix: state listener observe writes at wrong time Closes: #13457 Currently state listener is notified when the cache store write, which happens in commit event only, which breaks the current design. The solution (as discussed in the issue) is to listen state writes on rootmulti store only. It also changes the file streamer to output single data file for the writes in the whole block, since we can't distinguish writes from different stage of abci events. It adds new config items for file streamer: - streamers.file.output-metadata - streamers.file.stop-node-on-error - streamers.file.fsync synchronous abci call, and format doc fix comment update file streamer readme and fix typos typo * improve UX of file streamer, make it immediately usable after enabled - set default value to write_dir. - make write_dir based on home directory by default. - auto-create the directory if not exists. * get homePage from opts Co-authored-by: Marko <marbar3778@yahoo.com> (cherry picked from commit 1f91ee2) # Conflicts: # CHANGELOG.md # api/cosmos/base/store/v1beta1/listening.pulsar.go # baseapp/streaming.go # docs/architecture/adr-038-state-listening.md # server/config/toml.go # simapp/app_v2.go # store/cachemulti/store.go # store/iavl/store.go # store/mem/store.go # store/streaming/constructor.go # store/streaming/file/service.go # store/streaming/file/service_test.go # store/types/listening.pb.go # store/types/store.go
Configuration menu - View commit details
-
Copy full SHA for d64de1f - Browse repository at this point
Copy the full SHA d64de1fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 43c5018 - Browse repository at this point
Copy the full SHA 43c5018View commit details
Commits on Dec 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7ee85ac - Browse repository at this point
Copy the full SHA 7ee85acView commit details -
Configuration menu - View commit details
-
Copy full SHA for 33b13dc - Browse repository at this point
Copy the full SHA 33b13dcView commit details
Commits on Dec 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 81e7184 - Browse repository at this point
Copy the full SHA 81e7184View commit details
Commits on Dec 6, 2022
-
Configuration menu - View commit details
-
Copy full SHA for bd77b58 - Browse repository at this point
Copy the full SHA bd77b58View commit details -
Configuration menu - View commit details
-
Copy full SHA for 532dacb - Browse repository at this point
Copy the full SHA 532dacbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 482987c - Browse repository at this point
Copy the full SHA 482987cView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.