Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Check the signature returned by the ledger device against the public key in the keyring #14460

Merged
merged 6 commits into from
Jan 2, 2023
Merged

chore: Check the signature returned by the ledger device against the public key in the keyring #14460

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f9ec62f
Check the signature returned by the ledger device against the public …
zmanian Jan 2, 2023
8660fe3
Update crypto/keyring/keyring.go
tac0turtle Jan 2, 2023
e4e6cf5
Merge branch 'main' into zaki/wrong_ledger_error
julienrbrt Jan 2, 2023
5612dfe
Update crypto/keyring/keyring.go
zmanian Jan 2, 2023
4b9f570
Merge branch 'main' into zaki/wrong_ledger_error
zmanian Jan 2, 2023
e0a5d7f
Merge branch 'main' into zaki/wrong_ledger_error
julienrbrt Jan 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions crypto/keyring/keyring.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,10 @@ func SignWithLedger(k *Record, msg []byte) (sig []byte, pub types.PubKey, err er
return nil, nil, err
}

if !pub.VerifySignature(msg, sig) {
zmanian marked this conversation as resolved.
Show resolved Hide resolved
return nil, nil, errors.New("Ledger generated an invalid signature. Perhaps have multiple ledgers and need to try another one")
tac0turtle marked this conversation as resolved.
Show resolved Hide resolved
}

return sig, priv.PubKey(), nil
}

Expand Down