Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): update iavl to latest v0.19.x #14619

Closed
wants to merge 4 commits into from

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Jan 14, 2023

Description

Update iavl dependency to latest 0.19.x, adapt to new Export interface, and enjoy improved rollback performance.

Shall we tag a new 0.19.x release in iavl before we update dependency here, @tac0turtle ?


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do on Monday

@julienrbrt
Copy link
Member

This should be backported to v0.45 and v0.47 too right?

@julienrbrt julienrbrt added backport/0.45.x backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release labels Jan 16, 2023
@julienrbrt julienrbrt changed the title deps: update iavl to latest v0.19.x build(deps): update iavl to latest v0.19.x Jan 16, 2023
@yihuang
Copy link
Collaborator Author

yihuang commented Jan 17, 2023

This should be backported to v0.45 and v0.47 too right?

yes, they are using v0.19.x as well. can we make it into 0.46.8?

@julienrbrt
Copy link
Member

julienrbrt commented Jan 17, 2023

This should be backported to v0.45 and v0.47 too right?

yes, they are using v0.19.x as well. can we make it into 0.46.8?

Yes, as far as I know we wait for this version for re-testing and tagging 0.45.12 and 0.46.8.

@faddat
Copy link
Contributor

faddat commented Jan 17, 2023

Very excellent, thanks for your work on this @yihuang

@julienrbrt
Copy link
Member

This should be backported to v0.45 and v0.47 too right?

yes, they are using v0.19.x as well. can we make it into 0.46.8?

Unfortunately, more testing was required before tagging a v0.19.5. We've decided to go ahead and tag v0.46.8 already, without that change.

@tac0turtle
Copy link
Member

0.19.5-rc.1 is released, once we merge this pr, lets test on a few main nets

@tac0turtle
Copy link
Member

closing in favour of #14830, couldn't find your fork to cherry pick so created a new one, sorry

@tac0turtle tac0turtle closed this Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.47.x PR scheduled for inclusion in the v0.47's next stable release C:Store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants