-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(textual): Add client-side infra #14661
Conversation
Somewhat unrelated could you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK.
@@ -147,15 +162,20 @@ func TestSigVerification(t *testing.T) { | |||
gasLimit := testdata.NewTestGasLimit() | |||
|
|||
spkd := ante.NewSetPubKeyDecorator(suite.accountKeeper) | |||
svd := ante.NewSigVerificationDecorator(suite.accountKeeper, suite.clientCtx.TxConfig.SignModeHandler()) | |||
anteTxConfig := authtx.NewTxConfigWithTextual( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a bit confusing I think given that they both do the same thing. Except one with a bank keeper and the other using gRPC. Especially since one constructor lives in client and the other on in auth/tx.
If they were in the same file that would be easier to compare and see they do the same thing.
Co-authored-by: Jeancarlo Barrios <JeancarloBarrios@users.noreply.github.com>
* fix: bump ledger-cosmos-go * feat: update cosmos-sdk code for ledger-cosmos-go Inspired by cosmos#14661
* fix: bump ledger-cosmos-go * feat: update cosmos-sdk code for ledger-cosmos-go Inspired by cosmos#14661
Description
Closes: #13747
P2
, which can be 0 or 1. To achieve this, I needed to break some keyring APIs for this new argument, as well as add a newLedgerPrivKeyAminoJSON
interface so that ledger priv keys have 2Sign
methods.Manual Testing
I managed to sign on my Nano S by performing the following changes on this PR (see as diff):
simapp/app_v2.go
(won't be necessary after Add support to plug gogo's registry into Textual #14647)Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change