-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Refactor TxSearch #14758
Merged
Merged
refactor: Refactor TxSearch #14758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
reviewed
Jan 24, 2023
github-prbot
requested review from
a team,
JeancarloBarrios and
atheeshp
and removed request for
a team
January 26, 2023 20:35
19 tasks
tac0turtle
added
the
A:automerge
Automatically merge PR once all prerequisites pass.
label
Feb 21, 2023
e2e tests are broken, wont be able to debug this week. Will need to come back to it next week |
I think they just need to be updated to use |
julienrbrt
reviewed
Feb 23, 2023
julienrbrt
added
the
backport/v0.47.x
PR scheduled for inclusion in the v0.47's next stable release
label
Feb 24, 2023
julienrbrt
removed
the
backport/v0.47.x
PR scheduled for inclusion in the v0.47's next stable release
label
Feb 24, 2023
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #14727
Changelog
QueryTxsByEvents
to acceptquery
instead ofevents
GetTxsEventRequest.Events
fieldGetTxsEventRequest.Query
field which will be directly proxied to Tendermint'sTxSearch
RPC method, thus utilizing Tendermint's validation and query semanticsAuthor Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change