Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add application genesis #15031

Merged
merged 35 commits into from
Feb 22, 2023
Merged

feat: add application genesis #15031

merged 35 commits into from
Feb 22, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Feb 14, 2023

Description

Closes: #14954

  • Removed the e2e tests from genutil as it does not add any value compared to the current tests.

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@github-actions github-actions bot added the C:x/genutil genutil module issues label Feb 14, 2023
x/genutil/types/genesis.go Fixed Show fixed Hide fixed
x/genutil/types/genesis.go Fixed Show fixed Hide fixed
x/genutil/types/genesis.go Fixed Show fixed Hide fixed
x/genutil/types/genesis.go Fixed Show fixed Hide fixed
server/export.go Fixed Show fixed Hide fixed
@julienrbrt julienrbrt marked this pull request as ready for review February 17, 2023 00:04
@julienrbrt julienrbrt requested a review from a team as a code owner February 17, 2023 00:04
@github-prbot github-prbot requested review from a team, alexanderbez and likhita-809 and removed request for a team February 17, 2023 00:04
x/genutil/types/genesis.go Fixed Show fixed Hide fixed
@github-actions github-actions bot removed the C:x/bank label Feb 19, 2023
@julienrbrt
Copy link
Member Author

Mmh, looking at the last test.

Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to fix failing test, otherwise lgtm

@julienrbrt julienrbrt enabled auto-merge (squash) February 22, 2023 10:06
@julienrbrt julienrbrt merged commit 832517b into main Feb 22, 2023
@julienrbrt julienrbrt deleted the julien/app-genesis branch February 22, 2023 10:29
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:CLI C:x/auth C:x/genutil genutil module issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add app version to genesis.json
4 participants