Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: use cometbft in v0.45 #15089

Merged
merged 5 commits into from
Feb 24, 2023
Merged

build: use cometbft in v0.45 #15089

merged 5 commits into from
Feb 24, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Feb 20, 2023 •
edited
Loading

Description

ref: #14870

TODO

  • Wait for v0.34 tag
  • Cherry-pick fix: double close #13400 updating checksums.
  • Bump to go.19 (mention coordinated upgrade required if go bump)
  • Add release notes

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt
Copy link
Member Author

reopening when ready

@julienrbrt julienrbrt closed this Feb 21, 2023
@julienrbrt julienrbrt reopened this Feb 22, 2023
@julienrbrt
Copy link
Member Author

Due to https://github.com/cometbft/cometbft/blob/v0.34.27-alpha.2/go.mod#L55, we need to cherry-pick 0b64514 in v0.45 too.

@julienrbrt julienrbrt mentioned this pull request Feb 22, 2023
Merged
@julienrbrt julienrbrt marked this pull request as ready for review February 22, 2023 22:07
@julienrbrt julienrbrt added the S:blocked Status: Blocked label Feb 23, 2023
@github-actions github-actions bot added C:Rosetta Issues and PR related to Rosetta Type: CI labels Feb 24, 2023
@julienrbrt julienrbrt removed the S:blocked Status: Blocked label Feb 24, 2023
@julienrbrt julienrbrt merged commit 53db377 into release/v0.45.x Feb 24, 2023
@julienrbrt julienrbrt deleted the julien/045-cometbft branch February 24, 2023 14:13
@julienrbrt
Copy link
Member Author

When we get a final v0.34.27 we can tag final. For now, tagged a v0.45.15-rc.0 for already testing on mainnets.

@troian
Copy link
Contributor

troian commented Mar 2, 2023

@julienrbrt v0.34.27 is out. mind cutting v0.45.15?

@julienrbrt
Copy link
Member Author

@julienrbrt v0.34.27 is out. mind cutting v0.45.15?

We are still running a bunch of tests on final v0.45.15 and v0.46.11 and we will tag both.
Probably tomorrow or at worse begin next week.

@troian
Copy link
Contributor

troian commented Mar 2, 2023

@julienrbrt cool, thank you!

@troian
Copy link
Contributor

troian commented Mar 9, 2023

hey @julienrbrt. should we expect this to come or there are some issues revealing during testing?

@julienrbrt
Copy link
Member Author

hey @julienrbrt. should we expect this to come or there are some issues revealing during testing?

We've already tagged v0.46.11, v0.45.15 will come later today/tomorrow 👍🏾

@faddat faddat mentioned this pull request Mar 23, 2023
Closed
19 tasks
faddat pushed a commit to osmosis-labs/cosmos-sdk that referenced this pull request Jun 14, 2023
@julienrbrt @faddat
build: use cometbft in v0.45 (cosmos#15089)
c3b23cb
@faddat faddat mentioned this pull request Dec 11, 2023
Draft
19 tasks
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
@julienrbrt @JeancarloBarrios
build: use cometbft in v0.45 (cosmos#15089)
4779ce8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@aaronc aaronc Awaiting requested review from aaronc aaronc is a code owner

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

Assignees
No one assigned
Labels
C:Rosetta Issues and PR related to Rosetta Type: Build Type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julienrbrt @troian @tac0turtle