refactor: remove bytes/HexBytes

UPGRADING.md

@@ -4,6 +4,74 @@ This guide provides instructions for upgrading to specific versions of Cosmos SD
 
 ## [Unreleased]
 
+### Refactor:remove bytes/HexBytes
+
+The Cosmos SDK has removed the import of cmtbytes "github.com/cometbft/cometbft/libs/bytes".
+There is something changed.Due to the import changes, this is a breaking change. Chains need to remove **entirely** their imports in their codebase, from direct and indirects imports.
+
+* Remove `github.com/cometbft/cometbft/libs/bytes`
+* Replace All `cmtbytes.HexBytes` by `[]byte` except `*pb.go`files
+* Verify `github.com/cometbft/cometbft/libs/bytes` is not an indirect or direct dependency
+* Run `make proto-gen`
+
+### Protobuf
+
+The SDK is in the process of removing all `(gogoproto.casttype) = "github.com/cometbft/cometbft/libs/bytes.HexBytes"`.
+
+### test
+
+use `ctx.HeaderHash()` in `context_test.go` instead of `ctx.HeaderHash().Bytes()`
+use `[]byte("xxx")` instead of `bytes.HexBytes([]byte("xxx"))`
+
+### Modules
+
+#### `x/bank`
+
+All the bank removed `github.com/cometbft/cometbft/libs/bytes`
+All the bank functions or params are now renamed to use `[]byte` instead of `cmtbytes.HexBytes` or `bytes.HexBytes` across the SDK.
+
+#### `x/evidence`
+
+All the evidence removed `github.com/cometbft/cometbft/libs/bytes`
+All the evidence functions or params are now renamed to use `cmtbytes.HexBytes` or `bytes.HexBytes` instead of `[]byte` across the SDK
+
+renamed to use `strings.ToUpper(hex.EncodeToString(evidence.Hash()))` instead of `evidence.Hash().String()`
+
+as follows:
+
+```go
+func (k Keeper) SubmitEvidence(ctx sdk.Context, evidence exported.Evidence) error {
+	if _, ok := k.GetEvidence(ctx, evidence.Hash()); ok {
+		return errors.Wrap(types.ErrEvidenceExists, strings.ToUpper(hex.EncodeToString(evidence.Hash())))
+	}
+	if !k.router.HasRoute(evidence.Route()) {
+		return errors.Wrap(types.ErrNoEvidenceHandlerExists, evidence.Route())
+	}
+
+	handler := k.router.GetRoute(evidence.Route())
+	if err := handler(ctx, evidence); err != nil {
+		return errors.Wrap(types.ErrInvalidEvidence, err.Error())
+	}
+
+	ctx.EventManager().EmitEvent(
+		sdk.NewEvent(
+			types.EventTypeSubmitEvidence,
+			sdk.NewAttribute(types.AttributeKeyEvidenceHash, strings.ToUpper(hex.EncodeToString(evidence.Hash()))),
+		),
+	)
+
+	k.SetEvidence(ctx, evidence)
+	return nil
+}
+```
+
+#### `x/simulation`
+
+All the simulation removed `github.com/cometbft/cometbft/libs/bytes`
+All the simulation functions or params are now renamed to use `cmtbytes.HexBytes` or `bytes.HexBytes` instead of `[]byte` across the SDK
+
+## [Unreleased]
+
 ### Migration to CometBFT (Part 2)
 
 The Cosmos SDK has migrated in, its previous versions, to CometBFT.

client/query.go

@@ -7,7 +7,6 @@ import (
 
 	"github.com/cockroachdb/errors"
 	abci "github.com/cometbft/cometbft/abci/types"
-	cmtbytes "github.com/cometbft/cometbft/libs/bytes"
 	rpcclient "github.com/cometbft/cometbft/rpc/client"
 	"google.golang.org/grpc/codes"
 	"google.golang.org/grpc/status"
@@ -45,7 +44,7 @@ func (ctx Context) QueryWithData(path string, data []byte) ([]byte, int64, error
 // QueryStore performs a query to a CometBFT node with the provided key and
 // store name. It returns the result and height of the query upon success
 // or an error if the query fails.
-func (ctx Context) QueryStore(key cmtbytes.HexBytes, storeName string) ([]byte, int64, error) {
+func (ctx Context) QueryStore(key []byte, storeName string) ([]byte, int64, error) {
 	return ctx.queryStore(key, storeName, "key")
 }
 
@@ -129,7 +128,7 @@ func sdkErrorToGRPCError(resp abci.ResponseQuery) error {
 // query performs a query to a CometBFT node with the provided store name
 // and path. It returns the result and height of the query upon success
 // or an error if the query fails.
-func (ctx Context) query(path string, key cmtbytes.HexBytes) ([]byte, int64, error) {
+func (ctx Context) query(path string, key []byte) ([]byte, int64, error) {
 	resp, err := ctx.queryABCI(abci.RequestQuery{
 		Path:   path,
 		Data:   key,
@@ -145,7 +144,7 @@ func (ctx Context) query(path string, key cmtbytes.HexBytes) ([]byte, int64, err
 // queryStore performs a query to a CometBFT node with the provided a store
 // name and path. It returns the result and height of the query upon success
 // or an error if the query fails.
-func (ctx Context) queryStore(key cmtbytes.HexBytes, storeName, endPath string) ([]byte, int64, error) {
+func (ctx Context) queryStore(key []byte, storeName, endPath string) ([]byte, int64, error) {
 	path := fmt.Sprintf("/store/%s/%s", storeName, endPath)
 	return ctx.query(path, key)
 }

client/rpc/status.go

@@ -5,7 +5,6 @@ import (
 
 	"github.com/spf13/cobra"
 
-	"github.com/cometbft/cometbft/libs/bytes"
 	"github.com/cometbft/cometbft/p2p"
 	coretypes "github.com/cometbft/cometbft/rpc/core/types"
 
@@ -18,7 +17,7 @@ import (
 // ValidatorInfo is info about the node's validator, same as CometBFT,
 // except that we use our own PubKey.
 type validatorInfo struct {
-	Address     bytes.HexBytes
+	Address     []byte
 	PubKey      cryptotypes.PubKey
 	VotingPower int64
 }

proto/cosmos/evidence/v1beta1/query.proto

@@ -25,8 +25,7 @@ service Query {
 message QueryEvidenceRequest {
   // evidence_hash defines the hash of the requested evidence.
   // Deprecated: Use hash, a HEX encoded string, instead.
-  bytes evidence_hash = 1
-      [deprecated = true, (gogoproto.casttype) = "github.com/cometbft/cometbft/libs/bytes.HexBytes"];
+  bytes evidence_hash = 1 [deprecated = true];
 
   // hash defines the evidence hash of the requested evidence.
   //

types/context.go

@@ -6,7 +6,6 @@ import (
 
 	"cosmossdk.io/log"
 	abci "github.com/cometbft/cometbft/abci/types"
-	cmtbytes "github.com/cometbft/cometbft/libs/bytes"
 	cmtproto "github.com/cometbft/cometbft/proto/tendermint/types"
 	"github.com/cosmos/gogoproto/proto"
 
@@ -26,7 +25,7 @@ type Context struct {
 	baseCtx              context.Context
 	ms                   storetypes.MultiStore
 	header               cmtproto.Header
-	headerHash           cmtbytes.HexBytes
+	headerHash           []byte
 	chainID              string
 	txBytes              []byte
 	logger               log.Logger
@@ -72,7 +71,7 @@ func (c Context) BlockHeader() cmtproto.Header {
 }
 
 // HeaderHash returns a copy of the header hash obtained during abci.RequestBeginBlock
-func (c Context) HeaderHash() cmtbytes.HexBytes {
+func (c Context) HeaderHash() []byte {
 	hash := make([]byte, len(c.headerHash))
 	copy(hash, c.headerHash)
 	return hash

types/context_test.go

@@ -121,7 +121,7 @@ func (s *contextTestSuite) TestContextWithCustom() {
 	s.Require().Equal(meter, ctx.GasMeter())
 	s.Require().Equal(minGasPrices, ctx.MinGasPrices())
 	s.Require().Equal(blockGasMeter, ctx.BlockGasMeter())
-	s.Require().Equal(headerHash, ctx.HeaderHash().Bytes())
+	s.Require().Equal(headerHash, ctx.HeaderHash())
 	s.Require().False(ctx.WithIsCheckTx(false).IsCheckTx())
 	s.Require().Equal(zeroGasCfg, ctx.KVGasConfig())
 	s.Require().Equal(zeroGasCfg, ctx.TransientKVGasConfig())