-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: clean-up of #15151 #15219
chore: clean-up of #15151 #15219
Conversation
@@ -245,15 +245,11 @@ message Params { | |||
repeated cosmos.base.v1beta1.Coin expedited_min_deposit = 12 [(gogoproto.nullable) = false, (amino.dont_omitempty) = true]; | |||
|
|||
// burn deposits if a proposal does not meet quorum | |||
// | |||
// Since: cosmos-sdk 0.47 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is said on the message itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, if someone is migrating from v4 -> v5 they will not have the values set out in the migration in v5, how is this handled?
It is handled in migration v4 during the params migration (which happened in v0.47). |
You've made me notice proposal cancel parameter were not set in v5 migration however. |
Description
Some clean-up of #15151. Noticed them while backporting in #15218
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change