Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove previous header in Prepare/Process Proposal + provide chain id in baseapp + fix context for verifying txs #15303

Merged
merged 34 commits into from
Mar 13, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
5600add
fix: remove previous header to avoid inconsistencies in Prepare\/Proc…
facundomedica Mar 8, 2023
a07fd6f
nit
facundomedica Mar 8, 2023
fbe491f
get chain id from genesis
facundomedica Mar 8, 2023
ac12759
progress
facundomedica Mar 8, 2023
233a4a4
progress
facundomedica Mar 8, 2023
fe1cd5b
progress
facundomedica Mar 8, 2023
257f4be
progress
facundomedica Mar 8, 2023
06d2021
progress
facundomedica Mar 8, 2023
4a79357
progress
facundomedica Mar 8, 2023
71d93ca
progress
facundomedica Mar 8, 2023
755611d
progress
facundomedica Mar 8, 2023
be89d62
fix leak
facundomedica Mar 8, 2023
bf4c3f2
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into facu…
facundomedica Mar 8, 2023
d7e7bd8
Merge branch 'main' into facu/empty-header-prepproc-prop
facundomedica Mar 9, 2023
09ae43a
cl++
facundomedica Mar 9, 2023
a578ddb
add some extra checks and fix context for prepare and process proposal
facundomedica Mar 10, 2023
630175a
add some extra checks and fix context for prepare and process proposal
facundomedica Mar 10, 2023
950cd21
fix comment
facundomedica Mar 10, 2023
966dba8
fix e2e test in params
facundomedica Mar 10, 2023
820e34e
rm comment
facundomedica Mar 10, 2023
b17f178
attempt to simplify (#15348)
julienrbrt Mar 10, 2023
adfac48
Merge branch 'facu/empty-header-prepproc-prop' of https://github.com/…
facundomedica Mar 10, 2023
3f23381
fix
facundomedica Mar 10, 2023
3bcaa15
rollback rollback.go
facundomedica Mar 10, 2023
bc1b4c1
Merge branch 'main' into facu/empty-header-prepproc-prop
facundomedica Mar 10, 2023
f5e883e
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into facu…
facundomedica Mar 10, 2023
52a64aa
suggestions from @alexanderbez
facundomedica Mar 10, 2023
6b8b529
Merge branch 'main' into facu/empty-header-prepproc-prop
facundomedica Mar 13, 2023
02b6ad1
Merge branch 'main' into facu/empty-header-prepproc-prop
facundomedica Mar 13, 2023
143af44
Merge branch 'main' of https://github.com/cosmos/cosmos-sdk into facu…
facundomedica Mar 13, 2023
f307b3b
remove some unnecessary changes, like new lines
facundomedica Mar 13, 2023
89b90da
Merge branch 'facu/empty-header-prepproc-prop' of https://github.com/…
facundomedica Mar 13, 2023
ed69776
Merge branch 'main' into facu/empty-header-prepproc-prop
facundomedica Mar 13, 2023
814fc92
Merge branch 'main' into facu/empty-header-prepproc-prop
facundomedica Mar 13, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
cl++
  • Loading branch information
facundomedica committed Mar 9, 2023
commit 09ae43acf015ae25c4986a779e3f1e71eafdf2bc
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ Ref: https://keepachangelog.com/en/1.0.0/

### Bug Fixes

* (baseapp) [#15303](https://github.com/cosmos/cosmos-sdk/pull/15303) Remove previous block data from context before PrepareProposal + add ChainID to baseapp in order to pass it in the context.
facundomedica marked this conversation as resolved.
Show resolved Hide resolved
* (x/auth) [#15059](https://github.com/cosmos/cosmos-sdk/pull/15059) `ante.CountSubKeys` returns 0 when passing a nil `Pubkey`.
* (x/capability) [#15030](https://github.com/cosmos/cosmos-sdk/pull/15030) Prevent `x/capability` from consuming `GasMeter` gas during `InitMemStore`
* [#14995](https://github.com/cosmos/cosmos-sdk/pull/14995) Allow unknown fields in `ParseTypedEvent`.
Expand Down
2 changes: 1 addition & 1 deletion baseapp/abci.go
Original file line number Diff line number Diff line change
Expand Up @@ -982,7 +982,7 @@ func SplitABCIQueryPath(requestPath string) (path []string) {
func (app *BaseApp) getContextForProposal(ctx sdk.Context, height int64) sdk.Context {
if height == 1 {
ctx, _ = app.deliverState.ctx.CacheContext()
// TODO: clear all context data set during InitChain to avoid inconsistent behavior
// clear all context data set during InitChain to avoid inconsistent behavior
ctx = ctx.WithBlockHeader(cmtproto.Header{})
return ctx
}
Expand Down