Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: accaddr cachefix #15318

Closed

Conversation

KyleMoser
Copy link
Contributor

@KyleMoser KyleMoser commented Mar 9, 2023

Description

Closes: #15317

Note that I submitted the PR to the release branch since this issue is primarily fixing a bug for the go relayer which is currently using v0.47.0-rc1. That said, the bug likely applies to other clients as well and should make its way into main.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@KyleMoser KyleMoser self-assigned this Mar 9, 2023
@julienrbrt
Copy link
Member

If it is applicable to main, then could you please make a PR targeting main. Then we'll add the backport label for v0.47.

@tac0turtle tac0turtle changed the title Kamoser/accaddr cachefix fix: accaddr cachefix Mar 9, 2023
@KyleMoser
Copy link
Contributor Author

@julienrbrt ok, but it sounds like @tac0turtle thinks there will be a different fix in a future release. #15317

I will prep it the way you suggested unless that changes anything.

@KyleMoser KyleMoser mentioned this pull request Mar 16, 2023
19 tasks
@julienrbrt
Copy link
Member

Closing as #15433 replaces it.

@julienrbrt julienrbrt closed this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants