Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare v0.45.15 release #15346

Merged
merged 10 commits into from
Mar 22, 2023
Merged

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Mar 10, 2023

Description

Prepare v0.45.15 release.

cc @troian you can expect a tag after this PR is merged.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@troian
Copy link
Contributor

troian commented Mar 11, 2023

hey @julienrbrt getting following go mod error with github.com/cosmos/cosmos-sdk 1c967b8

❯ go mod tidy
github.com/akash-network/akash-api/go/node/audit/v1beta1 imports
    github.com/cosmos/cosmos-sdk/crypto/codec imports
    github.com/cosmos/cosmos-sdk/crypto/keys/secp256k1 imports
    github.com/btcsuite/btcd/btcec/v2/ecdsa tested by
    github.com/btcsuite/btcd/btcec/v2/ecdsa.test imports
    github.com/btcsuite/btcd/chaincfg/chainhash: ambiguous import: found package github.com/btcsuite/btcd/chaincfg/chainhash in multiple modules:
    github.com/btcsuite/btcd v0.20.1-beta (/Users/amr/go/pkg/mod/github.com/btcsuite/btcd@v0.20.1-beta/chaincfg/chainhash)
    github.com/btcsuite/btcd/chaincfg/chainhash v1.0.1 (/Users/amr/go/pkg/mod/github.com/btcsuite/btcd/chaincfg/chainhash@v1.0.1)

@troian
Copy link
Contributor

troian commented Mar 11, 2023

go.sum for julien/release-04515

@julienrbrt
Copy link
Member Author

hey @julienrbrt getting following go mod error with github.com/cosmos/cosmos-sdk 1c967b8

❯ go mod tidy
github.com/akash-network/akash-api/go/node/audit/v1beta1 imports
    github.com/cosmos/cosmos-sdk/crypto/codec imports
    github.com/cosmos/cosmos-sdk/crypto/keys/secp256k1 imports
    github.com/btcsuite/btcd/btcec/v2/ecdsa tested by
    github.com/btcsuite/btcd/btcec/v2/ecdsa.test imports
    github.com/btcsuite/btcd/chaincfg/chainhash: ambiguous import: found package github.com/btcsuite/btcd/chaincfg/chainhash in multiple modules:
    github.com/btcsuite/btcd v0.20.1-beta (/Users/amr/go/pkg/mod/github.com/btcsuite/btcd@v0.20.1-beta/chaincfg/chainhash)
    github.com/btcsuite/btcd/chaincfg/chainhash v1.0.1 (/Users/amr/go/pkg/mod/github.com/btcsuite/btcd/chaincfg/chainhash@v1.0.1)

You have to try to remove the btcd dependency of your app when upgrading.

I am still testing on the Cosmos Hub as statesync is an issue (while it shouldn't be btw). Would you be able to tell us for Akash?

@troian
Copy link
Contributor

troian commented Mar 11, 2023

the issue is, we don't use btcd, all its references are indirect in the go.mod

@troian
Copy link
Contributor

troian commented Mar 11, 2023

I am still testing on the Cosmos Hub as statesync is an issue (while it shouldn't be btw). Would you be able to tell us for Akash?

i suppose you meant test?

@julienrbrt
Copy link
Member Author

I am still testing on the Cosmos Hub as statesync is an issue (while it shouldn't be btw). Would you be able to tell us for Akash?

i suppose you meant test?

Yes, but I've tried to bump akash-network/node without any issue. Have you updated the CometBFT replace as well?

@troian
Copy link
Contributor

troian commented Mar 15, 2023

this issue is poping up here
i put chainhash dependency intentionally for tests to pass. if we remove it error above happens

@julienrbrt julienrbrt marked this pull request as ready for review March 20, 2023 13:55
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@julienrbrt julienrbrt enabled auto-merge (squash) March 22, 2023 09:43
@julienrbrt julienrbrt merged commit c0fe4f7 into release/v0.45.x Mar 22, 2023
@julienrbrt julienrbrt deleted the julien/release-04515 branch March 22, 2023 09:46
@faddat faddat mentioned this pull request Mar 23, 2023
19 tasks
JeancarloBarrios pushed a commit to agoric-labs/cosmos-sdk that referenced this pull request Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants