Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add event core api to runtime #15547

Merged
merged 14 commits into from
Mar 30, 2023
Merged

feat: add event core api to runtime #15547

merged 14 commits into from
Mar 30, 2023

Conversation

tac0turtle
Copy link
Member

Description

Closes: #14690

Opening this pr to get initial feedback on the approach. If this is good then i can plumb it through baseapp


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@tac0turtle tac0turtle requested a review from a team as a code owner March 25, 2023 11:34
@github-actions

This comment has been minimized.

runtime/events.go Fixed Show fixed Hide fixed
runtime/events.go Fixed Show fixed Hide fixed
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add a few simple test cases for this type.

Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, changelog is somewhat... undescriptive.
linter is complaining as well.

Copy link
Member

@aaronc aaronc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be some tests and runtime needs to provide this service to modules.

@tac0turtle
Copy link
Member Author

There should be some tests and runtime needs to provide this service to modules.

where should the tests exist? runtime doesnt seem to have tests

runtime/module.go Outdated Show resolved Hide resolved
@tac0turtle tac0turtle enabled auto-merge (squash) March 30, 2023 14:07
@tac0turtle tac0turtle merged commit 9a09f86 into main Mar 30, 2023
@tac0turtle tac0turtle deleted the marko/14690 branch March 30, 2023 14:16
nicolaslara pushed a commit to osmosis-labs/cosmos-sdk that referenced this pull request Mar 31, 2023
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
larry0x pushed a commit to larry0x/cosmos-sdk that referenced this pull request May 22, 2023
Co-authored-by: Facundo Medica <14063057+facundomedica@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support core API events
5 participants