Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(x/gov): move ValidateBasic to msg server #15832

Merged
merged 15 commits into from
Apr 17, 2023
Merged

refactor(x/gov): move ValidateBasic to msg server #15832

merged 15 commits into from
Apr 17, 2023

Conversation

atheeshp
Copy link
Contributor

@atheeshp atheeshp commented Apr 13, 2023 •
edited
Loading

Description

ref: #15648

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@atheeshp atheeshp requested a review from julienrbrt April 13, 2023 11:58
@atheeshp atheeshp marked this pull request as ready for review April 13, 2023 12:19
@atheeshp atheeshp requested a review from a team as a code owner April 13, 2023 12:19
@atheeshp atheeshp requested a review from julienrbrt April 13, 2023 12:19
@github-prbot github-prbot requested review from a team and JeancarloBarrios and removed request for a team April 13, 2023 12:23
julienrbrt
julienrbrt reviewed Apr 13, 2023
View reviewed changes
x/gov/keeper/msg_server.go Outdated Show resolved Hide resolved
x/gov/keeper/msg_server.go Outdated
return nil, errors.Wrap(govtypes.ErrNoProposalMsgs, "either metadata or Msgs length must be non-nil")
}

msgs, err := msg.GetMsgs()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we extract that check in a smaller function as well for readbility?

@julienrbrt julienrbrt mentioned this pull request Apr 13, 2023
Closed
19 tasks
julienrbrt
julienrbrt reviewed Apr 14, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! One nit

x/gov/keeper/msg_server.go Outdated Show resolved Hide resolved
julienrbrt
julienrbrt requested changes Apr 17, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not reintroduce bech32 global deps. You should look at the auth keeper string to bytes checks and move them up when necessary. Something is up in e2e as well.

x/gov/keeper/msg_server.go Outdated Show resolved Hide resolved
x/gov/keeper/msg_server.go Outdated Show resolved Hide resolved
x/gov/keeper/msg_server.go Outdated Show resolved Hide resolved
x/gov/keeper/msg_server.go Outdated Show resolved Hide resolved
@atheeshp atheeshp requested a review from julienrbrt April 17, 2023 10:49
julienrbrt
julienrbrt approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

likhita-809
likhita-809 approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@likhita-809 likhita-809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tac0turtle tac0turtle enabled auto-merge April 17, 2023 13:10
@tac0turtle tac0turtle added this pull request to the merge queue Apr 17, 2023
Merged via the queue into main with commit debf1fa Apr 17, 2023
@tac0turtle tac0turtle deleted the ap/gov-validate-basic branch April 17, 2023 15:33
@jonfung-dydx jonfung-dydx mentioned this pull request Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@likhita-809 likhita-809 likhita-809 approved these changes

@julienrbrt julienrbrt julienrbrt approved these changes

@JeancarloBarrios JeancarloBarrios Awaiting requested review from JeancarloBarrios

Assignees

@JeancarloBarrios JeancarloBarrios

@julienrbrt julienrbrt

Labels
C:x/gov
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atheeshp @julienrbrt @likhita-809 @JeancarloBarrios @tac0turtle