Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update slashing and evidence module for ICS #15907

Closed
wants to merge 2 commits into from

Conversation

sainoe
Copy link
Contributor

@sainoe sainoe commented Apr 21, 2023

Description

The ICS consumer module doesn't store validators' pubkeys in the slashing module making the slashing and evidence modules either panicing or no-oping when these keys aren't stored see:

if _, err := k.GetPubkey(ctx, addr); err != nil {

if _, err := k.slashingKeeper.GetPubkey(ctx, consAddr.Bytes()); err != nil {

This PR removes these two checks in order to work with ICS.

Note that this line was previously added to the evidence module by #13122 for the same reason.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@sainoe sainoe requested a review from a team as a code owner April 21, 2023 12:09
@github-actions
Copy link
Contributor

@sainoe your pull request is missing a changelog!

@sainoe sainoe closed this Apr 21, 2023
@tac0turtle tac0turtle deleted the sainoe/evidence-deadcode branch February 21, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant