feat: update slashing and evidence module for ICS #15907
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ICS consumer module doesn't store validators' pubkeys in the slashing module making the slashing and evidence modules either panicing or no-oping when these keys aren't stored see:
cosmos-sdk/x/slashing/keeper/infractions.go
Line 19 in 9acdbb9
cosmos-sdk/x/evidence/keeper/infraction.go
Line 30 in 9acdbb9
This PR removes these two checks in order to work with ICS.
Note that this line was previously added to the evidence module by #13122 for the same reason.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change