refactor(x/authz)!: Use KVStoreService, context.Context and return errors instead of panic #15962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facundomedica
commented
Apr 26, 2023
Comment on lines
-330
to
+356
| if len(queueItems.MsgTypeUrls) == 0 { | ||
| k.setGrantQueueItem(ctx, expiration, granter, grantee, &authz.GrantQueueItem{ | ||
| MsgTypeUrls: []string{msgType}, | ||
| }) | ||
| } else { | ||
| queueItems.MsgTypeUrls = append(queueItems.MsgTypeUrls, msgType) | ||
| k.setGrantQueueItem(ctx, expiration, granter, grantee, queueItems) | ||
| } | ||
|
|
||
| return nil | ||
| queueItems.MsgTypeUrls = append(queueItems.MsgTypeUrls, msgType) | ||
| return k.setGrantQueueItem(ctx, expiration, granter, grantee, queueItems) |
facundomedica
changed the title
facundomedica
commented
Apr 26, 2023
| func (k Keeper) getGrant(ctx sdk.Context, skey []byte) (grant authz.Grant, found bool) { | ||
| store := ctx.KVStore(k.storeKey) | ||
| bz := store.Get(skey) | ||
| func (k Keeper) getGrant(ctx context.Context, skey []byte) (grant authz.Grant, found bool) { |
There was a problem hiding this comment.
We might want to modify this to return also an error? I'm not sure
There was a problem hiding this comment.
since its internal i think its fine
github-prbot
requested review from
a team,
tac0turtle and
julienrbrt
and removed request for
a team
|
#15948 contains the fixes for the linter and the simapp v1 tests |
julienrbrt
changed the title
larry0x
pushed a commit
to larry0x/cosmos-sdk
that referenced
this pull request
May 22, 2023
…rors instead of panic (cosmos#15962)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #XXXX
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change