Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable sign mode textual by default #15970

Merged
merged 15 commits into from
Jun 1, 2023
Merged

Conversation

facundomedica
Copy link
Member

@facundomedica facundomedica commented Apr 27, 2023

Description

Note: I'm not adding it to DefaultSignModes given that it requires the bank keeper or a gRPC connection and in many cases we don't have that (like in tests).

Closes: #11970


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@facundomedica facundomedica marked this pull request as ready for review May 5, 2023 12:33
@facundomedica facundomedica requested a review from a team as a code owner May 5, 2023 12:33
@github-prbot github-prbot requested review from a team, tac0turtle and julienrbrt and removed request for a team May 5, 2023 12:33
@github-actions

This comment has been minimized.

x/auth/tx/config.go Show resolved Hide resolved
x/auth/tx/config/config.go Outdated Show resolved Hide resolved
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK.

@facundomedica facundomedica added this pull request to the merge queue Jun 1, 2023
Merged via the queue into main with commit b3c4e15 Jun 1, 2023
@facundomedica facundomedica deleted the facu/enable-signmodetx branch June 1, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement SIGN_MODE_TEXTUAL
5 participants