Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: default to noop mempool when max-txs is negative #16071

Merged
merged 3 commits into from
May 9, 2023
Merged

Conversation

julienrbrt
Copy link
Member

Description

Closes: #13874 / #13874 (comment)


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@julienrbrt julienrbrt requested a review from a team as a code owner May 9, 2023 12:44
@github-prbot github-prbot requested review from a team, samricotta and testinginprod and removed request for a team May 9, 2023 12:45
@julienrbrt julienrbrt added this pull request to the merge queue May 9, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 9, 2023
@julienrbrt julienrbrt added this pull request to the merge queue May 9, 2023
@julienrbrt
Copy link
Member Author

Merge queue failed because of GitHub API being flaky...

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 9, 2023
@julienrbrt julienrbrt added this pull request to the merge queue May 9, 2023
Merged via the queue into main with commit 0da5e83 May 9, 2023
@julienrbrt julienrbrt deleted the julien/mempool branch May 9, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mempool: non validator nodes should not have to run the mempool
3 participants