Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Infinite Feegrant Bug #16097

Merged
merged 2 commits into from
May 11, 2023
Merged

Fix Infinite Feegrant Bug #16097

merged 2 commits into from
May 11, 2023

Commits on May 11, 2023

  1. Infinite feegrant bug test 

    This test is designed to reproduce an infinite Feegrant bug that occurs when using AllowedMsgAllowance with an internal BasicAllowance.

I suspect that this line (https://github.com/scrtlabs/cosmos-sdk/blob/61091b357e/x/feegrant/basic_fee.go#L31) does not update the internal BasicAllowance after using part of the grant. This may be related to this line (https://github.com/scrtlabs/cosmos-sdk/blob/61091b357e/x/feegrant/filtered_fee.go#L47) as well.
    @assafmo
    assafmo committed May 11, 2023
    Configuration menu
    Copy the full SHA
    64aa225 View commit details
    Browse the repository at this point in the history

  2. Fix infinite feegrant bug 

    The internal allowance update in AllowedMsgAllowance was never propagated to the parent AllowedMsgAllowance.
    @assafmo
    assafmo committed May 11, 2023
    Configuration menu
    Copy the full SHA
    034306f View commit details
    Browse the repository at this point in the history