refactor(gov)!: use collections for Proposal state management (part 1) #16171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 16, 2023 05:54
testinginprod
commented
May 16, 2023
| suite.Require().Nil(err) | ||
| suite.Require().Equal(proposal, gotProposal) | ||
| } | ||
| } | ||
|
|
||
| // TODO(tip): remove this |
testinginprod
commented
May 16, 2023
| @@ -18,6 +14,7 @@ import ( | |||
| "github.com/cosmos/cosmos-sdk/x/gov/types/v1beta1" | |||
| ) | |||
|
|
|||
| // TODO(tip): remove this | |||
testinginprod
changed the title
added 3 commits
May 16, 2023 07:08
github-prbot
requested review from
a team,
JeancarloBarrios and
atheeshp
and removed request for
a team
tac0turtle
approved these changes
May 16, 2023
julienrbrt
reviewed
May 16, 2023
| @@ -60,11 +60,8 @@ func (keeper Keeper) IterateDeposits(ctx context.Context, proposalID uint64, cb | |||
| // Activates voting period when appropriate and returns true in that case, else returns false. | |||
| func (keeper Keeper) AddDeposit(ctx context.Context, proposalID uint64, depositorAddr sdk.AccAddress, depositAmount sdk.Coins) (bool, error) { | |||
| // Checks to see if proposal exists | |||
| proposal, err := keeper.GetProposal(ctx, proposalID) | |||
| proposal, err := keeper.Proposals.Get(ctx, proposalID) | |||
| if err != nil { | |||
There was a problem hiding this comment.
Do you think it isn't necessary to do a check of collections.ErrNotFound for keeping the same behavior?
There was a problem hiding this comment.
I think we can use the ErrNotFound of collections which is more descriptive and standardized. This breaks consensus but it does not break state compatibility so I think it should be fine, it also allowed us to remove some errors from gov which I think are a little overkill.
If you think this is not good I can revert the changes in a PR.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially Closes: #16172
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change