Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bank): AfterSendCoins Hooks in the bank module #16234

Closed
wants to merge 9 commits into from

Conversation

BrickBera
Copy link

@BrickBera BrickBera commented May 19, 2023

Description

This PR implements after send hooks to the BaseSendKeeper. Other modules will be able to register hooks to this module. This PR continues the closed PR #14660
Closes issue: #14701

x/bank/send.go
x/bank/types/hooks.go
x/bank/module.go


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@BrickBera
Copy link
Author

BrickBera commented May 19, 2023

@SpicyLemon has made a similar PR 14224, and left some good comments in issue 14701, thank you. I agree there is no reason to have separate before/after hooks, and I agree PR 14224 behaves similar to a BeforeSendCoins hook.
I still made this PR because:

  1. This is a more generic hook, which not only does sendRestriction (I know it's just a name)
  2. In our use case, it makes sense to do it after SendCoins because if SendCoins fails, it can revert earlier without wasting time in hooks.

@github-actions
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Jun 26, 2023
@github-actions github-actions bot closed this Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants